Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document auto #1385

Merged
merged 14 commits into from
Mar 31, 2023
Merged

document auto #1385

merged 14 commits into from
Mar 31, 2023

Conversation

tophtucker
Copy link
Contributor

@tophtucker tophtucker commented Mar 24, 2023

for #1343

src/marks/auto.d.ts Outdated Show resolved Hide resolved
src/marks/auto.d.ts Outdated Show resolved Hide resolved
src/marks/auto.d.ts Outdated Show resolved Hide resolved
src/marks/auto.d.ts Outdated Show resolved Hide resolved
@tophtucker tophtucker marked this pull request as ready for review March 27, 2023 17:46
src/marks/auto.d.ts Outdated Show resolved Hide resolved
@tophtucker tophtucker changed the title Draft: jsdoc comments for auto mark document auto Mar 27, 2023
src/marks/auto.d.ts Outdated Show resolved Hide resolved
src/marks/auto.d.ts Outdated Show resolved Hide resolved
src/marks/auto.d.ts Outdated Show resolved Hide resolved
@mbostock mbostock enabled auto-merge (squash) March 31, 2023 22:03
@mbostock mbostock merged commit f469f7f into main Mar 31, 2023
@mbostock mbostock deleted the toph/auto-jsdoc branch March 31, 2023 22:04
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* Draft: jsdoc comments for auto mark

* channel names in boldface, string option in italics

Co-authored-by: Philippe Rivière <[email protected]>

* Update src/marks/auto.d.ts

Co-authored-by: Philippe Rivière <[email protected]>

* option (strings) in italics, marks in bold

Co-authored-by: Philippe Rivière <[email protected]>

* add more auto jsdocs

* Correct column name in jsdoc example

Co-authored-by: Philippe Rivière <[email protected]>

* correct column name

* MarkType jsdoc

* typo

Co-authored-by: Philippe Rivière <[email protected]>

* edits

* checkpoint edits

* fix AutoSpec["color"] type

* edits

* edits

---------

Co-authored-by: Philippe Rivière <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants