avoid a crash on facet: exclude on a non-faceted mark #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1281
mbostock
requested changes
Feb 17, 2023
src/plot.js
Outdated
| @@ -100,6 +100,7 @@ export function plot(options = {}) { | |||
| for (const mark of marks) { | |||
| if (mark.facet === "exclude") { | |||
| const facetState = facetStateByMark.get(mark); | |||
| if (facetState === undefined) throw new Error(`the facet: "exclude" option is restricted to top-level facets`); | |||
There was a problem hiding this comment.
This isn’t accurate—you can also use facet: "exclude" if you specify mark-level faceting, e.g.
Plot.dot(penguins, {facet: "exclude", fx: "sex", fy: "species", x: "culmen_depth_mm", y: "culmen_length_mm", r: 2, fill: "#ddd"}),
|
We should be consistent when the facet option is activated (ie not undefined) on a non-faceted mark: either ignore all cases, or error all cases. Currently we ignore all cases but crash on "exclude". This can be fixed by changing that line to:
I'm not sure erroring on all cases would bring much, but it's an alternative. |
Fil
changed the title
Fil
commented
Feb 21, 2023
mbostock
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1281