feat: Use ReportHeartbeat OpAmp capability #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eartbeat interval, generate w/ latest mockery
dpaasman00
force-pushed
the
dakotapaasman/bpop-164-implement-heartbeat-in-bindplane-agent
branch
from
dba22cb to
1f85dff
Compare
dpaasman00
deleted the
dakotapaasman/bpop-164-implement-heartbeat-in-bindplane-agent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Updates opamp-go dependency to v0.19.0 so we can set ReportsHeartbeat Capability and set default with empty interval to disable by default. The idea is if the agent connects to an older BP version, the heartbeats will cause BP to hit the store constantly, so disable heartbeats by default. Newer BP versions won't hit the store anymore and will set this interval on the agent during the first connection.
Also runs
make generatewith updated Mockeryhttps://linear.app/bindplane/issue/BPOP-164/implement-heartbeat-in-bindplane-agent
Checklist