feat: Use timeout for Dial in secops forwarder #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
commented
Jan 30, 2025
dpaasman00
commented
Jan 30, 2025
Comment on lines
+61
to
+63
| d := new(net.Dialer) | ||
| d.Timeout = fc.timeout | ||
| return tls.DialWithDialer(d, network, addr, config) |
There was a problem hiding this comment.
This is meant to be identical to what tls.Dial normally does except we're setting a timeout instead now: https://cs.opensource.google/go/go/+/refs/tags/go1.23.5:src/crypto/tls/tls.go;l=173
mrsillydog
approved these changes
Jan 30, 2025
dpaasman00
force-pushed
the
dakotapaasman/bpop-1720-bdot-long-delay-when-rolling-out-a-config-with-non-working
branch
from
4966c3c to
e41d447
Compare
dpaasman00
deleted the
dakotapaasman/bpop-1720-bdot-long-delay-when-rolling-out-a-config-with-non-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Call the
Dialfunctions with a timeout to exit early in the case of a bad IP address.Uses the timeout already present in the configuration from the squashed
confignet.AddrConfig. This way when BP starts adding this param to the exporter config it is backwards compatibleChecklist