-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix axioms on uncinate fasciculus and added disjoint for brainstem #2343
Conversation
relationship: overlaps UBERON:0002275 ! reticular formation | ||
relationship: overlaps UBERON:0002298 ! brainstem | ||
relationship: overlaps UBERON:0002726 ! cervical spinal cord | ||
relationship: overlaps UBERON:0003023 {source="NIFSTD"} ! pontine tegmentum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawntanzk I'd remove the NIFSTD source, because it's not the source of this overlaps rel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was there on the part_of relation from before - I wonder if it shows provenance? cause the definition doesn't mention pons/pontine tegmentum at all. Will try to look into NIFSTD to check this, if not find why this is there from literature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth keeping as NIFSTD is at least the source of a partonomy relationship, even if they didn't choose the right one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok trying to open NIF on protege is killing it lol, im going to assume that the partonomy relationship is there (don't see partonomy relationships in general on bioportal where the user facing nif is at) - either way, since it was there before I think it should be kept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawntanzk I added a comment. Other than that, all looks good to me and ready to merge.
Fixes #2341 (change part of to overlaps, and added a whole bunch of overlaps that is in the textual definition but not in logical definition)
Fixes #2342