Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdv-xport-service POST routes have too many arguments #45

Closed
janjagusch opened this issue Jun 4, 2020 · 3 comments
Closed

gdv-xport-service POST routes have too many arguments #45

janjagusch opened this issue Jun 4, 2020 · 3 comments

Comments

@janjagusch
Copy link

Hi!

Looking at the Swagger UI, two routes seem to have too many arguments:

From what I understand, both of them should accept text and the datenpaket route should also accept format. However, the also accept two more body arguments. I have attached a screenshot for clarity:

image

I believe something is wrong in the Swagger specification but am not able to locate it (when we work with OpenAPI, we usually define an app.yml file).

Would be awesome, if you could take a look at it! 😃

@oboehm
Copy link
Owner

oboehm commented Jun 4, 2020

It looks like a misuse of the Swagger annotations in DatenpaketController. I will take a look to it at the weekend.

@oboehm
Copy link
Owner

oboehm commented Jun 5, 2020

The swagger documentation is now updated on the dev develop branch. Also the Dockerfile and POM was updated to build it via Docker.

oboehm added a commit that referenced this issue Jun 5, 2020
* 'develop' of github.com:oboehm/gdv.xport:
  #47: Dokumentation zu Build und Dockerfile ergänzt
  #45: Swagger-Doku auf @ApiParam (statt @ApiImplicitParam) umgestellt
@oboehm
Copy link
Owner

oboehm commented Jun 8, 2020

v4.1.0 is out where Swagger documentation is fixed - see release notes
So this ticket is closed now.

@oboehm oboehm closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants