Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#851): Use Full Object Name For Bytes, bytes -> org.eolang.bytes #861

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Nov 13, 2024

In this PR I extendent the bytes attribute with org.eolang package.
Now we have full org.eolang.bytes name for all values.

Also I tried to remove @data attribute from org.eolang.bytes object and failed. When we do this, eo-maven-plugin:xmir-to-phi goal removes all the bytes.

Related to #851, #850


PR-Codex overview

This PR updates the attribute base from "bytes" to "org.eolang.bytes" across various Java files, enhancing clarity and consistency in the codebase related to byte representation.

Detailed summary

  • Changed base attribute from "bytes" to "org.eolang.bytes" in DirectivesBytes.java.
  • Updated XPath expressions in DirectivesValuesTest.java, DirectivesSeqTest.java, and HasMethod.java to reflect the new base.
  • Modified XML output in DirectivesClassTest.java and DirectivesClassPropertiesTest.java to use the updated base.
  • Adjusted checks in HasLabel.java to match the new base attribute.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 13, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 4a025d5 into objectionary:master Nov 13, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Nov 13, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 11min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants