-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(#3300): refactored PhPackage
#3895
bug(#3300): refactored PhPackage
#3895
Conversation
@yegor256 please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon looks like you turned linting off
@yegor256 no, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon got it, thanks!
@rultor release, tag is |
@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 22min).
|
@rultor release, tag is |
@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 29min).
|
Ref: #3300
In this PR I refactored
PhPackage
class. The refactoring allowed to increaseeo-runtime
build time from 45s to 22s on my laptop. Also I made retrieval attributes from package objects more strictUPD: Also I fixed many
.eo
files so now we get less warnigns bylint
goal