Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3300): refactored PhPackage #3895

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Feb 6, 2025

Ref: #3300

In this PR I refactored PhPackage class. The refactoring allowed to increase eo-runtime build time from 45s to 22s on my laptop. Also I made retrieval attributes from package objects more strict

UPD: Also I fixed many .eo files so now we get less warnigns by lint goal

@github-actions github-actions bot added the core label Feb 6, 2025
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon looks like you turned linting off

eo-runtime/pom.xml Show resolved Hide resolved
@maxonfjvipon
Copy link
Member Author

@yegor256 no, compile includes deps + assemble + lint

@yegor256 yegor256 enabled auto-merge February 7, 2025 07:26
Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon got it, thanks!

@yegor256 yegor256 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into objectionary:master with commit a828139 Feb 7, 2025
22 checks passed
@yegor256
Copy link
Member

yegor256 commented Feb 7, 2025

@rultor release, tag is 0.51.1

@rultor
Copy link
Contributor

rultor commented Feb 7, 2025

@rultor release, tag is 0.51.1

@yegor256 OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Feb 7, 2025

@rultor release, tag is 0.51.1

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 22min).

    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
Caused by: com.sonatype.nexus.staging.client.StagingRuleFailuresException: Staging rules failure!
    at com.sonatype.nexus.staging.client.internal.StagingWorkflowV3ServiceImpl.monitorRepositoryTransition (StagingWorkflowV3ServiceImpl.java:272)
    at com.sonatype.nexus.staging.client.internal.StagingWorkflowV2ServiceImpl.monitorRepositoryTransition (StagingWorkflowV2ServiceImpl.java:407)
    at com.sonatype.nexus.staging.client.internal.StagingWorkflowV2ServiceImpl$10.perform (StagingWorkflowV2ServiceImpl.java:281)
    at com.sonatype.nexus.staging.client.internal.StagingWorkflowV2ServiceImpl$10.perform (StagingWorkflowV2ServiceImpl.java:276)
    at com.sonatype.nexus.staging.client.internal.ExceptionConverter.runAndReturn (ExceptionConverter.java:38)
    at com.sonatype.nexus.staging.client.internal.StagingWorkflowV2ServiceImpl.releaseStagingRepositories (StagingWorkflowV2ServiceImpl.java:285)
    at com.sonatype.nexus.staging.client.internal.StagingWorkflowV3ServiceImpl.releaseStagingRepositories (StagingWorkflowV3ServiceImpl.java:91)
    at org.sonatype.nexus.maven.staging.workflow.ReleaseStageRepositoryMojo.doExecute (ReleaseStageRepositoryMojo.java:55)
    at org.sonatype.nexus.maven.staging.workflow.AbstractStagingActionMojo.execute (AbstractStagingActionMojo.java:55)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :eo-runtime
\u001b[0m\u001b[0mcontainer 3262b3d3fe3232a06e9cfed02fc84969092685c7ed8e27fcd6d223b9d1420d28 is dead
Fri Feb  7 09:04:36 UTC 2025

@yegor256
Copy link
Member

yegor256 commented Feb 7, 2025

@rultor release, tag is 0.51.2

@rultor
Copy link
Contributor

rultor commented Feb 7, 2025

@rultor release, tag is 0.51.2

@yegor256 OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Feb 7, 2025

@rultor release, tag is 0.51.2

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 29min).

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for eo 0.51.2:
[INFO] 
[INFO] eo ................................................. SUCCESS [  7.979 s]
[INFO] eo-parser .......................................... SUCCESS [ 13.008 s]
[INFO] eo-maven-plugin .................................... SUCCESS [ 17.719 s]
[INFO] eo-runtime ......................................... SUCCESS [12:01 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12:44 min
[INFO] Finished at: 2025-02-07T10:20:06Z
[INFO] ------------------------------------------------------------------------
\u001b[0m\u001b[0mbranch 'gh-pages' set up to track 'origin/gh-pages'.
Switched to a new branch 'gh-pages'
HEAD is now at dcd6c3d3a Deploying to gh-pages from @ objectionary/eo@a828139d873868266efecda3ade4799b86c04ff2 🚀
Using /usr/local/rvm/gems/ruby-3.2.2
Using /usr/local/rvm/gems/ruby-3.2.2
Using /usr/local/rvm/gems/ruby-3.2.2
Using /usr/local/rvm/gems/ruby-3.2.2
[gh-pages d79b690a4] XMIR XSD 0.51.2
 2 files changed, 491 insertions(+), 1 deletion(-)
 create mode 100644 xsd/XMIR-0.51.2.xsd
[gh-pages 102b603eb] objectionary 0.51.2
 110 files changed, 1193 insertions(+), 1372 deletions(-)
 rename objectionary/tests/org/eolang/{cti-test.eo => cti-tests.eo} (94%)
 rename objectionary/tests/org/eolang/io/{bytes-as-input-test.eo => bytes-as-input-tests.eo} (93%)
 rename objectionary/tests/org/eolang/io/{console-test.eo => console-tests.eo} (92%)
 rename objectionary/tests/org/eolang/io/{malloc-as-output-test.eo => malloc-as-output-tests.eo} (94%)
 rename objectionary/tests/org/eolang/io/{stdout-test.eo => stdout-tests.eo} (93%)
Switched to branch '__rultor'
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R ubuntu repo
+ cd repo
+ git checkout __rultor
Already on '__rultor'
+ git tag 0.51.2 -m '0.51.2: tagged by rultor.com'
+ git reset --hard
HEAD is now at 6da0bd5e6 0.51.2
+ git clean -fd
+ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
+ git branch -D __rultor
Deleted branch __rultor (was 6da0bd5e6).
+ git push --all origin
To github.com:objectionary/eo.git
 ! [rejected]            gh-pages -> gh-pages (fetch first)
error: failed to push some refs to 'github.com:objectionary/eo.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
container 684f59b3da90ee6a46e65adda63c207432b18eb1b9d44422a28b667e2a3e589b is dead
Fri Feb  7 10:21:00 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants