Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xnav for better performance in some places #3849

Merged
merged 6 commits into from
Jan 25, 2025
Merged

xnav for better performance in some places #3849

merged 6 commits into from
Jan 25, 2025

Conversation

yegor256
Copy link
Member

closes #3847

@yegor256 yegor256 marked this pull request as draft January 24, 2025 16:20
@github-actions github-actions bot added the core label Jan 24, 2025
@yegor256 yegor256 marked this pull request as ready for review January 25, 2025 15:37
@yegor256 yegor256 enabled auto-merge January 25, 2025 15:38
@yegor256
Copy link
Member Author

@maxonfjvipon please, check this one

@yegor256 yegor256 requested a review from maxonfjvipon January 25, 2025 15:38
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 just one suggestion

eo-parser/src/test/java/benchmarks/XslBench.java Outdated Show resolved Hide resolved
@yegor256 yegor256 requested a review from maxonfjvipon January 25, 2025 17:54
@yegor256 yegor256 added this pull request to the merge queue Jan 25, 2025
Merged via the queue into master with commit 31c194e Jan 25, 2025
22 checks passed
@yegor256 yegor256 deleted the 3847 branch January 25, 2025 18:49
@0crat
Copy link

0crat commented Jan 25, 2025

@yegor256 Thank you for your contribution! Here's your reward breakdown: +4 base points, -8 for exceeding 200 hits-of-code (214,407), -16 for surpassing 800 hits-of-code, -16 for no code review, and -4 for only 3 comments. To maintain a minimum reward, we've added 44 points. Your final score is +4 points, with a running balance of -352. Remember, quality over quantity is key. Keep contributing, but aim for smaller, more focused changes with proper reviews next time! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xnav may help us translate to XMIR faster
3 participants