-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The HSE compiler #318
The HSE compiler #318
Conversation
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 89.12% 89.12%
Complexity 79 79
=========================================
Files 6 6
Lines 285 285
Branches 30 30
=========================================
Hits 254 254
Misses 25 25
Partials 6 6 Continue to review full report at Codecov.
|
eo-maven-plugin/src/main/java/org/eolang/maven/CompileMojo.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/pom.xml
Outdated
<artifactId>hamcrest-core</artifactId> | ||
<version>1.3</version> | ||
<scope>test</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nlchar this is redundant, we have it coming from the parent. Just delete it here, I'm sure everything will work just fine.
@nlchar many thanks! Looks very good, however I've made a few comments above. |
@yegor256 thank you for the review. I've tried to cover all of your comments. Please, have a look one more time. |
Could you release this repo in case if the pr is ok, please? |
@nlchar hold on, let me check what's going on... I can't reproduce this locally |
@rultor merge |
@nlchar @yegor256 Oops, I failed. You can see the full log here (spent 26s)
|
@rultor merge |
@nlchar @yegor256 Oops, I failed. You can see the full log here (spent 2min)
|
@nlchar I just did this on the server, where Rultor is working (Ubuntu 18):
It seems that something is wrong with the master branch. I will try to fix now. |
@nlchar I think it's fixed, but you need to merge |
Thank you, Yegor. |
@rultor merge |
@nlchar houray! thanks! |
@rultor release, tag is |
@nlchar @yegor256 Oops, I failed. You can see the full log here (spent 10min)
|
@rultor release, tag is |
Job |
@nlchar @yegor256 Oops, I failed. You can see the full log here (spent 9min)
|
@rultor release, tag is |
Rultor release pipeline seems to be ruined 🥺 |
@nlchar it's too strict, not ruined :) |
No description provided.