PHI/UNPHI Removes Objects With as Attribute

[volodya-lombrozo]

I run the following integration test:

bytecode -> (disassemble) xmir -> phi -> unphi -> unroll -> xmir (assemble) -> bytecode.

And this test fails because phi/unphi alter the original xmir file.

Steps to reproduce:

1. I generate App.xmir from App.class file (jeo:disassemble).
2. Then I use eo:0.50.0:xmir-to-phi to generate App.phi (eo:xmir-to-phi).
3. Then I run eo:0.50.0:phi-to-xmir to generate App.xmir (eo:phi-to-xmir).
4. Then I run jeo:unroll and get exceptions about incorrect xmir (jeo:unroll`).

Actually, phi/unphi loose <o as="body-1299402125" base="jeo.seq.of3"> object. Later I see the following error:

Can't find object with attribute as='body' in ...

Expected behaviour:

App.xmir.disassemble.txt and App.xmir.unphi.txt files should be the same. In other words, phi/unphi does not
have to change the original xmir file.

Actual behaviour:

App.xmir.disassemble.txt and App.xmir.unphi.txt files are different. phi/unphi significantly changes the original xmir.

Details:

App.phi.txt
App.xmir.disassemble.txt
App.xmir.unphi.txt
App.xmir.unroll.txt

[volodya-lombrozo]

Blocks: objectionary/jeo-maven-plugin#969

[volodya-lombrozo]

I tried to change XMIR according with this suggestion.

[volodya-lombrozo]

@maxonfjvipon Could you help with this issue, please?

[maxonfjvipon]

@volodya-lombrozo the original XMIR is not really valid because of duality in application bindings. I created a ticket in lints, let's wait until it's implemented. Then you use the new version of linst with this check and we'll get back to this problem again.

[maxonfjvipon]

@volodya-lombrozo but also there's a bug in to-phi.xsl, I'll try to fix it

[maxonfjvipon]

@yegor256 let's make a new release

[yegor256]

@rultor release, tag is 0.50.1

[rultor]

@rultor release, tag is 0.50.1

@yegor256 OK, I will release it now. Please check the progress here.

[rultor]

@rultor release, tag is 0.50.1

@yegor256 Done! FYI, the full log is here (took me 11min).

[maxonfjvipon]

@volodya-lombrozo please try new version, maybe it resolves your problem, but also don't forget about this

[volodya-lombrozo]

@maxonfjvipon I'm getting the following during the unroll phase:

Caused by: java.lang.IllegalArgumentException: Path '/org/eolang/parser/add-default-package.xsl' not found in classpath

Can I simply remove add-default-package.xsl from jeo:unroll?

[volodya-lombrozo]

@maxonfjvipon Same about /org/eolang/parser/explicit-data.xsl'

Here is my Java code

 private static XML unroll(final XML parsed) {
        return new Xsline(
            new TrFast(
                new TrJoined<Shift>(
                    new TrClasspath<>(
                        "/org/eolang/parser/wrap-method-calls.xsl"
                    ).back(),
                    new TrDefault<>(
                        new StEndless(
                            new StClasspath(
                                "/org/eolang/parser/roll-bases.xsl"
                            )
                        )
                    ),
                    new TrClasspath<>(
                        "/org/eolang/parser/add-refs.xsl",
                        "/org/eolang/parser/add-cuts.xsl"
                    ).back(),
                    new TrDefault<Shift>(
                        new StEndless(
                            new StClasspath(
                                "/org/eolang/parser/vars-float-down.xsl"
                            )
                        )
                    ),
                    new TrClasspath<Shift>(
                        "/org/eolang/parser/remove-cuts.xsl",
//                        "/org/eolang/parser/add-default-package.xsl",
                        "/org/eolang/parser/explicit-data.xsl"
                    ).back()
                ),
                CanonicalXmir.class,
                5
            )
        ).pass(parsed);
    }

[maxonfjvipon]

@volodya-lombrozo these xsls were moved to /org/eolang/parser/shake directory, please update it, but don't remove

[volodya-lombrozo]

@volodya-lombrozo please try new version, maybe it resolves your problem, but also don't forget about this

@maxonfjvipon Unfortunately, it didn't help (I see the same error.)

[maxonfjvipon]

@volodya-lombrozo please send me your disassembled XMIR and PHI

[volodya-lombrozo]

@maxonfjvipon Sure. Here they are:

App.xmir.disassemble.txt
App.phi.txt
App.xmir.unphi.txt
App.xmir.unroll.txt

[maxonfjvipon]

@volodya-lombrozo are you sure, you use the newest version?
I've just tried it on your disassembled XMIR and I got this phi which looks correctly:

phi.txt

[volodya-lombrozo]

@maxonfjvipon You are absolutely right! I've just forgotten to update objectionary/eo in the test itself. My bad.

Thank you for the help and for the fix.