Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to unimplemented! messages #540

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

fprasx
Copy link
Contributor

@fprasx fprasx commented Jan 18, 2024

The first time I ran trustfall_stubgen this is what I saw:

thread 'main' panicked at~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/trustfall_core-0.7.1/src/schema/mod.rs:163:46:
not implemented
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This should alleviate that a bit. At some point, we should also have a reference detailing the difference between Trustfall and GraphQl schemas.

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, all of this is stuff we should support someday but isn't a high priority right now, since Trustfall is quite usable without it.

@obi1kenobi obi1kenobi enabled auto-merge (squash) January 18, 2024 20:46
@obi1kenobi obi1kenobi added A-schema Area: the data model that queries use C-maintainability Category: reduce maintenance burden, e.g. by clearing tech debt or improving test infra L-rust Language: affects use cases in the Rust programming language labels Jan 18, 2024
auto-merge was automatically disabled January 19, 2024 04:49

Head branch was pushed to by a user without write access

@fprasx
Copy link
Contributor Author

fprasx commented Jan 19, 2024

Pushed a format, should pass now

@obi1kenobi obi1kenobi enabled auto-merge (squash) January 19, 2024 04:59
@obi1kenobi obi1kenobi merged commit 4239637 into obi1kenobi:main Jan 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema Area: the data model that queries use C-maintainability Category: reduce maintenance burden, e.g. by clearing tech debt or improving test infra L-rust Language: affects use cases in the Rust programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants