Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: move user rights checking from if to native decorators #117

Closed
obervinov opened this issue Nov 12, 2024 · 0 comments · Fixed by #123
Closed

Feature request: move user rights checking from if to native decorators #117

obervinov opened this issue Nov 12, 2024 · 0 comments · Fixed by #123
Assignees
@obervinov
Labels
enhancement New feature or request
Milestone
v.3.3.0

Comments

@obervinov
Copy link
Owner

obervinov commented Nov 12, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Right now, permissions are checked every time through explicit if insertion and custom context building. This makes the code overloaded and creates redundant code duplication.
We should try to move these functions to decorators, as for example it is done in the database module to get credentials from vault.

Describe the solution you'd like
obervinov/users-package#52

Describe alternatives you've considered
None

Additional context
None
@obervinov obervinov added the enhancement New feature or request label Nov 12, 2024
@obervinov obervinov self-assigned this Nov 12, 2024
@obervinov obervinov added this to the v.3.3.0 milestone Nov 12, 2024
@obervinov obervinov linked a pull request Dec 10, 2024 that will close this issue
Release v3.3.0: Add support for downloading account content and bug fixes #123
Merged
@github-actions github-actions bot mentioned this issue Dec 20, 2024
Merged
obervinov added a commit that referenced this issue Dec 21, 2024
@obervinov
Release v3.3.0: Add support for downloading account content and bug f…
44a1446 
…ixes (#123)

## v3.3.0 - 2024-12-21
### What's Changed
**Full Changelog**: v3.2.0...v3.3.0 by @obervinov in #123
#### 🐛 Bug Fixes
* small code formatting improvements
#### 🚀 Features
* add new table `accounts` to the database for storing account public data
* add the feature to retrieve the entire list of account posts and add it to the queue
* #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obervinov obervinov

Labels
enhancement New feature or request
Projects
@obervinov's Pyinstabot-Downloader
Status: Done
Milestone
v.3.3.0
1 participant
@obervinov