bump skylib version; fix ppx transform bug

obazl · Jan 12, 2024 · b7c236b · b7c236b
1 parent 7ab9f4c
commit b7c236b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -7,4 +7,4 @@ module(
 
 bazel_dep(name = "platforms",    version = "0.0.8")
 bazel_dep(name = "rules_cc",     version = "0.0.9")
-bazel_dep(name = "bazel_skylib", version = "1.4.2")
+bazel_dep(name = "bazel_skylib", version = "1.5.0")
diff --git a/ocaml/_rules/impl_ppx_transform.bzl b/ocaml/_rules/impl_ppx_transform.bzl
@@ -78,6 +78,8 @@ def impl_ppx_transform(rule, ctx, srcfile, dst):
 
     ## FIXME: add ctx.attr._ppx_print as build flag, ctx.attr.ppx_print as string override
     if hasattr(ctx.attr, "ppx_print"):
+        # fail(ctx.attr.ppx_print[BuildSettingInfo].value)
+
         # rule == ocaml_module, ocaml_signature
         if ctx.attr.ppx_print[BuildSettingInfo].value == "binary":
             if hasattr(ctx.attr, "args"):