-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing information into event ResourceDeleted #1148
Merged
bartlomiejmarszal
merged 5 commits into
develop
from
fix/ADF-1857/ResourceDeleted-resourceType
Feb 17, 2025
Merged
Add missing information into event ResourceDeleted #1148
bartlomiejmarszal
merged 5 commits into
develop
from
fix/ADF-1857/ResourceDeleted-resourceType
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceab7ac
to
cb37f46
Compare
Karol-Stelmaczonek
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
pnal
reviewed
Jan 24, 2025
Unit tests please |
tikhanovichA
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
@bartlomiejmarszal could you please check unit tests? |
Version
There are 0 BREAKING CHANGE, 1 feature, 4 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Add Resource Type to ResourceDeleted Event
Summary
This pull request introduces a new feature to the
ResourceDeleted
event by adding aresourceType
property. This enhancement allows for more detailed event handling by specifying the type of resource that has been deleted.Key Changes
ResourceDeleted Class:
resourceType
to store the type of the resource.setResourceType
andgetResourceType
methods to manage theresourceType
property.jsonSerialize
method to include theresourceType
in the serialized data.ResourceRepository Class:
$resource->getTypes()
and set it in theResourceDeleted
event using the newsetResourceType
method.Benefits
ResourceDeleted
event, consumers of the event can make more informed decisions based on the type of resource that was deleted.Notes