Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: control status blocking before chain init with runtimes #5407

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Oct 19, 2023

The first commit adds the early-query scenario for runtimes and does some minor needed refactoring so that the base Scenario struct implements the Scenario interface.

Second one fixes the issue (runtime.Host() doesn't wait for the registry descriptor anymore, which was blocking the GetStatus query).

TODO: also backport to stable/23.0.x once approved

@ptrus ptrus marked this pull request as ready for review October 19, 2023 10:14
@ptrus ptrus force-pushed the ptrus/fix/blocking-status branch 2 times, most recently from 3bfed37 to 65c93c1 Compare October 19, 2023 10:22
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5407 (22d3afd) into master (26ffcfb) will increase coverage by 0.31%.
Report is 1 commits behind head on master.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master    #5407      +/-   ##
==========================================
+ Coverage   66.54%   66.85%   +0.31%     
==========================================
  Files         533      533              
  Lines       56323    56328       +5     
==========================================
+ Hits        37478    37660     +182     
+ Misses      14419    14270     -149     
+ Partials     4426     4398      -28     
Files Coverage Δ
go/oasis-node/cmd/node/node_control.go 67.41% <100.00%> (+9.11%) ⬆️
go/runtime/registry/registry.go 77.57% <85.71%> (+2.29%) ⬆️
go/runtime/registry/host.go 65.85% <50.00%> (-0.19%) ⬇️

... and 52 files with indirect coverage changes

@ptrus ptrus force-pushed the ptrus/fix/blocking-status branch 2 times, most recently from 6a79a62 to c7de0d0 Compare October 19, 2023 10:54
@ptrus ptrus force-pushed the ptrus/fix/blocking-status branch from c7de0d0 to 5c4215b Compare October 19, 2023 10:55
@ptrus ptrus force-pushed the ptrus/fix/blocking-status branch from 5c4215b to 22d3afd Compare October 19, 2023 13:09
@ptrus ptrus merged commit 0d68f8a into master Oct 19, 2023
@ptrus ptrus deleted the ptrus/fix/blocking-status branch October 19, 2023 13:43
ptrus added a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants