tests: Multiple txsource fixes #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/ci-txsource
branch
from
a5ea3e5 to
cb9ded1
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
ptrus
approved these changes
Feb 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #5192 +/- ##
==========================================
- Coverage 61.58% 61.51% -0.08%
==========================================
Files 512 512
Lines 53980 53980
==========================================
- Hits 33244 33205 -39
- Misses 16509 16565 +56
+ Partials 4227 4210 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternose
reviewed
Feb 21, 2023
| @@ -302,6 +303,8 @@ func (r *registration) Run( // nolint: gocyclo | |||
| } | |||
| } | |||
| } | |||
| // Cleanup temporary identities directory after generation. | |||
| _ = os.RemoveAll(nodeIdentitiesDir) | |||
There was a problem hiding this comment.
Any special reason why removing twice?
| @@ -256,6 +254,9 @@ func (r *registration) Run( // nolint: gocyclo | |||
|
|
|||
| entityAccs[i].nodeIdentities = append(entityAccs[i].nodeIdentities, &nodeAcc{ident, nodeDesc, nodeAccNonce}) | |||
| ent.Nodes = append(ent.Nodes, ident.NodeSigner.Public()) | |||
|
|
|||
| // Cleanup temporary node identity directory after generation. | |||
| _ = os.RemoveAll(dataDir) | |||
There was a problem hiding this comment.
Move higher and use defer inside func to remove also on error.
| if isSynced, _ := q.control.IsSynced(loopCtx); !isSynced { | ||
| _ = q.control.WaitSync(loopCtx) | ||
| time.Sleep(1 * time.Second) | ||
| continue |
There was a problem hiding this comment.
It's a good practice to always cancel context.
We are stealing time from query timeout when syncing, not sure if a problem.
If the node never syncs, we never gracefully exit the loop.
I think one line could be removed.
if err = q.control.WaitSync(loopCtx); err != nil {
time.Sleep(time.Second)
continue
}
``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.