Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Propagate CheckTx errors #4551

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 8, 2022

No description provided.

@kostko kostko force-pushed the kostko/feature/p2p-prop-checktx-err branch 3 times, most recently from 7be571e to a83bbb6 Compare March 8, 2022 10:07
@kostko kostko marked this pull request as ready for review March 8, 2022 10:36
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #4551 (a83bbb6) into master (048ea00) will decrease coverage by 0.09%.
The diff coverage is 87.50%.

❗ Current head a83bbb6 differs from pull request most recent head ad49c99. Consider uploading reports for the commit ad49c99 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4551      +/-   ##
==========================================
- Coverage   67.08%   66.99%   -0.10%     
==========================================
  Files         424      424              
  Lines       47757    47772      +15     
==========================================
- Hits        32038    32003      -35     
- Misses      11802    11835      +33     
- Partials     3917     3934      +17     
Impacted Files Coverage Δ
go/worker/common/committee/p2p.go 80.00% <76.92%> (+1.05%) ⬆️
go/runtime/registry/registry.go 75.44% <100.00%> (+0.26%) ⬆️
go/runtime/txpool/txpool.go 81.58% <100.00%> (+0.25%) ⬆️
go/worker/compute/executor/committee/p2p.go 75.00% <100.00%> (ø)
go/worker/compute/executor/tests/tester.go 85.33% <100.00%> (+0.19%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af089cd...ad49c99. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/p2p-prop-checktx-err branch from a83bbb6 to ad49c99 Compare March 8, 2022 10:36
@kostko kostko enabled auto-merge March 8, 2022 11:24
@kostko kostko force-pushed the kostko/feature/p2p-prop-checktx-err branch from ad49c99 to 82a36f1 Compare March 9, 2022 12:25
@kostko kostko merged commit 857bc92 into master Mar 9, 2022
@kostko kostko deleted the kostko/feature/p2p-prop-checktx-err branch March 9, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants