go/runtime: Remove tag indexer #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
added
c:breaking/cfg
kostko
force-pushed
the
kostko/feature/rt-remove-tagindexer
branch
from
63001bd to
b8e9546
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
pro-wh
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
confirming that the runtime sdk didn't use this
(edit) to elaborate: watching blocks had been the way to go. may reconsider if we later reinstate this functionality with a more reliable implementation
pretty clean, that the removal is almost all deletions
I see that the end to end test is slightly enhanced to wait for a round
approving, but anyone else feel free to discuss too
| github.com/btcsuite/btcutil v1.0.2 | ||
| github.com/cenkalti/backoff/v4 v4.1.1 | ||
| github.com/dgraph-io/badger/v2 v2.2007.2 | ||
| github.com/dgraph-io/badger/v3 v3.2103.1 | ||
| github.com/eapache/channels v1.1.0 | ||
| github.com/facebookgo/ensure v0.0.0-20200202191622-63f1cf65ac4c // indirect | ||
| github.com/facebookgo/subset v0.0.0-20200203212716-c811ad88dec4 // indirect |
There was a problem hiding this comment.
This is the result of running go mod tidy, let me look into it a bit.
kostko
force-pushed
the
kostko/feature/rt-remove-tagindexer
branch
from
b8e9546 to
9093c12
Compare
Codecov Report
@@ Coverage Diff @@
## master #4216 +/- ##
==========================================
- Coverage 68.67% 68.59% -0.08%
==========================================
Files 411 408 -3
Lines 47549 46936 -613
==========================================
- Hits 32652 32197 -455
+ Misses 10848 10750 -98
+ Partials 4049 3989 -60
Continue to review full report at Codecov.
|
ptrus
approved these changes
Aug 30, 2021
kostko
force-pushed
the
kostko/feature/rt-remove-tagindexer
branch
from
9093c12 to
f69222c
Compare
tjanez
added a commit
that referenced
this pull request
Oct 18, 2021
Tag indexer was removed in #4216.
tjanez
added a commit
that referenced
this pull request
Oct 18, 2021
Tag indexer was removed in #4216.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3888
Closes #3388
Closes #1674
The tag indexer is slow, buggy and unused by the SDK. Runtime transaction
indexing and querying capabilities should be provided as part of the new
event streaming API.