Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/client: Add GetTransactions method, deprecate GetTxs #3982

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 1, 2021

A new method called GetTransactions has been added to replace the now deprecated
GetTxs. The new method does not require the caller to pass the IO root as that
is an internal detail. This makes it consistent with the existing GetEvents API.

Users of GetTxs should migrate to GetTransactions as the former may be removed
in a future release.

@kostko kostko linked an issue Jun 1, 2021 that may be closed by this pull request
@kostko kostko force-pushed the kostko/feature/rt-cli-gettxs-noroot branch from 66ba825 to 54f4398 Compare June 1, 2021 10:26
@kostko kostko force-pushed the kostko/feature/rt-cli-gettxs-noroot branch from 54f4398 to 14ccd2b Compare June 1, 2021 11:32
A new method called GetTransactions has been added to replace the now deprecated
GetTxs. The new method does not require the caller to pass the IO root as that
is an internal detail. This makes it consistent with the existing GetEvents API.

Users of GetTxs should migrate to GetTransactions as the former may be removed
in a future release.
@kostko kostko force-pushed the kostko/feature/rt-cli-gettxs-noroot branch from 14ccd2b to ecb4130 Compare June 1, 2021 11:36
@kostko kostko marked this pull request as ready for review June 1, 2021 11:37
@kostko kostko enabled auto-merge June 1, 2021 11:38
@kostko kostko merged commit a69c989 into master Jun 1, 2021
@kostko kostko deleted the kostko/feature/rt-cli-gettxs-noroot branch June 1, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IORoot from GetTxsRequest
2 participants