Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint/apps/roothash: Clear timeout in emitEmptyBlock #3213

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 25, 2020

TODO

  • Cleanup

@kostko kostko force-pushed the kostko/fix/rt-round-timeout branch from f9324d1 to 48735dd Compare August 25, 2020 17:09
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #3213 into master will increase coverage by 0.11%.
The diff coverage is 74.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
+ Coverage   67.47%   67.58%   +0.11%     
==========================================
  Files         370      370              
  Lines       36011    36098      +87     
==========================================
+ Hits        24299    24398      +99     
+ Misses       8589     8541      -48     
- Partials     3123     3159      +36     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/roothash/roothash.go 74.17% <41.37%> (-3.50%) ⬇️
...nsus/tendermint/apps/supplementarysanity/checks.go 47.90% <45.45%> (-0.18%) ⬇️
go/roothash/tests/tester.go 89.72% <90.16%> (-0.31%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 78.57% <94.44%> (+1.10%) ⬆️
go/storage/metrics.go 77.02% <0.00%> (-8.11%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 78.72% <0.00%> (-4.26%) ⬇️
go/storage/api/root_cache.go 74.60% <0.00%> (-3.18%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c6f98...a7c5872. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/rt-round-timeout branch 2 times, most recently from a676a71 to cb85383 Compare August 25, 2020 19:41
@kostko kostko force-pushed the kostko/fix/rt-round-timeout branch from cb85383 to a7c5872 Compare August 26, 2020 07:38
@kostko kostko marked this pull request as ready for review August 26, 2020 07:38
@kostko kostko merged commit f4db6a5 into master Aug 26, 2020
@kostko kostko deleted the kostko/fix/rt-round-timeout branch August 26, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants