-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/worker/storage: Add initial sync from checkpoints #3181
Conversation
6702fa2
to
dcd86c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to also have some failure case tests, e.g., something like a Byzantine storage node that we could test against. Maybe for another issue.
595397c
to
7a68cf5
Compare
Codecov Report
@@ Coverage Diff @@
## master #3181 +/- ##
==========================================
+ Coverage 67.43% 67.84% +0.41%
==========================================
Files 370 371 +1
Lines 36541 36864 +323
==========================================
+ Hits 24640 25009 +369
+ Misses 8702 8679 -23
+ Partials 3199 3176 -23
Continue to review full report at Codecov.
|
0971968
to
67d5e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem to be failing?
2e5bda6
to
199beeb
Compare
199beeb
to
f35f5e3
Compare
f35f5e3
to
d7f57c1
Compare
c727310
to
8478b21
Compare
cafc40b
to
5e67de8
Compare
Could you add a configuration flag, e.g. |
2b5cbc9
to
247897e
Compare
247897e
to
29e5473
Compare
Closes #2479