Add markdownlint #2662
Merged
Add markdownlint #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2662 +/- ##
=======================================
Coverage 63.09% 63.09%
=======================================
Files 365 365
Lines 34587 34587
=======================================
+ Hits 21822 21823 +1
+ Misses 10048 10047 -1
Partials 2717 2717
Continue to review full report at Codecov.
|
kostko
reviewed
Feb 10, 2020
| line-length: | ||
| # Line length checking is not strict by default. | ||
| strict: true | ||
| line_length: 80 |
There was a problem hiding this comment.
Nothing in particular, 80 is something I'm most used to.
kostko
reviewed
Feb 10, 2020
tjanez
force-pushed
the
tjanez/add-markdownlint
branch
2 times, most recently
from
5836ec2 to
795377e
Compare
tjanez
force-pushed
the
tjanez/add-markdownlint
branch
from
795377e to
005ddb3
Compare
kostko
approved these changes
Feb 12, 2020
Add Lint Markdown files and Lint Change Log fragments steps to ci-lint GitHub Actions workflow.
It is more familiar to developers and prevents confusion between requiring a Change Log fragment's subject line to end with period and requiring a Git commit message's subject line not to end with a period.
tjanez
force-pushed
the
tjanez/add-markdownlint
branch
from
005ddb3 to
546dfaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2572.
TODO:
gitlintto lint the Change Log fragments.