This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
ledger-signer: Don't try to split cfgStr if none is specified #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Jul 30, 2020
Yawning
suggested changes
Jul 30, 2020
This should give a better error message when the user didn't specify a valid signer configuration, i.e. it will return "address not configured" instead of "malformed k/v pair: ''".
tjanez
force-pushed
the
tjanez/signer-improvements
branch
from
017637d to
3f76f58
Compare
tjanez
changed the title
Yawning
approved these changes
Jul 31, 2020
kostko
approved these changes
Jul 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give a better error message when the user didn't specify a valid signer configuration, i.e. it will return "address not configured" instead of "malformed k/v pair: ''".
The second commit is an implementation of this part of https://github.com/oasisprotocol/oasis-core/issues/3134:Removed that commit, replaced by oasisprotocol/oasis-core@fa213e7.