-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate empty report correctly #828
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
/rerun |
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5890445 |
On Python2, the json.dumps library can produce either unicode or str output. Nowadays, the unicode is required, however in case the input for json.dumps function does not contain any unicode objects (e.g. when no report entry exists), it produces str type. Relates: oamg#821
374584a
to
a1b899e
Compare
@fernflower aah. copy&paste error /o\ should be fixed now |
Text files should have empty newline in the end of the file to be POSIX compatible.
/rerun |
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5890572 |
Testing Farm request for RHEL-7.9-rhui/5886104;5890445 regression testing has been created. |
Testing Farm request for RHEL-8.6-rhui/5886104;5890572 regression testing has been created. |
Testing Farm request for RHEL-7.9-rhui/5886104;5890572 regression testing has been created. |
/rerun |
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5900120 |
Testing Farm request for RHEL-8.6-rhui/5886104;5900120 regression testing has been created. |
Testing Farm request for RHEL-7.9-rhui/5886104;5900120 regression testing has been created. |
Testing Farm request for RHEL-8.6.0-Nightly/5886104;5900120 regression testing has been created. |
Testing Farm request for RHEL-8.8.0-Nightly/5886104;5900120 regression testing has been created. |
Testing Farm request for RHEL-7.9-ZStream/5886104;5900120 regression testing has been created. |
Testing Farm request for RHEL-7.9-ZStream/5886104;5900120 regression testing has been created. |
## Packaging - Provide leapp-framework 5.0 (oamg#818, oamg#840) ## Framework ### Fixes - Improve processing of reports with UTF-8 characters (oamg#821, oamg#828) - Fix info reporting with only one path to log (oamg#834) ### Enhancements - Include tracebacks of actors into the leapp.db (oamg#832) ## Leapp (tool) ### Fixes - Dialog creation fails not more for a component without choices (oamg#826) - Empty report is generated correctly (oamg#828) - Fix processing data in remediation instructions with non-ascii characters () ### Enhancements - Improve report summary output to make it more visible (oamg#818, oamg#840) ## stdlib ### Fixes - Fixed the call when the execute cannot be performed (oamg#836) ### Enhancements - changes related just to stdlib - under leapp/libraries/stdlib
## Packaging - Provide leapp-framework 5.0 (oamg#818, oamg#840) ## Framework ### Fixes - Improve processing of reports with UTF-8 characters (oamg#821, oamg#828) - Fix info reporting with only one path to log (oamg#834) ### Enhancements - Include tracebacks of actors into the leapp.db (oamg#832) ## Leapp (tool) ### Fixes - Dialog creation fails not more for a component without choices (oamg#826) - Empty report is generated correctly (oamg#828) - Fix processing data in remediation instructions with non-ascii characters () ### Enhancements - Improve report summary output to make it more visible (oamg#818, oamg#840) ## stdlib ### Fixes - Fixed the call when the execute cannot be performed (oamg#836) ### Enhancements - changes related just to stdlib - under leapp/libraries/stdlib
## Packaging - Provide leapp-framework 5.0 (#818, #840) ## Framework ### Fixes - Improve processing of reports with UTF-8 characters (#821, #828) - Fix info reporting with only one path to log (#834) ### Enhancements - Include tracebacks of actors into the leapp.db (#832) ## Leapp (tool) ### Fixes - Dialog creation fails not more for a component without choices (#826) - Empty report is generated correctly (#828) - Fix processing data in remediation instructions with non-ascii characters () ### Enhancements - Improve report summary output to make it more visible (#818, #840) ## stdlib ### Fixes - Fixed the call when the execute cannot be performed (#836) ### Enhancements - changes related just to stdlib - under leapp/libraries/stdlib
On Python2, the json.dumps library can produce either unicode or str output. Nowadays, the unicode is required, however in case the input for json.dumps function does not contain any unicode objects (e.g. when no report entry exists), it produces str type.
Also ensure the generated json file has the empty newline in the end of the file.
Relates: #821
JIRA: OAMG-8996
Additional info:
Original issue when an empty report has been generated: