Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute report Tags/Flags with report Groups #677

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Substitute report Tags/Flags with report Groups #677

merged 5 commits into from
Jun 16, 2022

Conversation

fernflower
Copy link
Member

No description provided.

@fernflower fernflower added the wip label Nov 12, 2020
@centos-ci
Copy link

Can one of the admins verify this patch?

@leapp-bot
Copy link
Collaborator

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the
Leapp Guidelines and must pass all tests in order to be mergable.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests, copr build and e2e tests in OAMG CI
  • e2e tests to run unit tests, copr build and end-to-end tests in Murphy CI (OAMG members only) [OLD PIPELINE]
  • review please to notify leapp developers of review request

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 12, 2020
@fernflower
Code changes to make transition to reporting.Groups
a62fb97 
Tags\Flags substituted by Groups

Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 13, 2020
@fernflower
Code changes to make transition to reporting.Groups
0d8ee90 
Tags\Flags substituted by Groups

Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 18, 2020
@fernflower
Adapt tests to the change
72e6a51 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 18, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
0231109 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 18, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
064e9fa 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 19, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
924c274 
Depends-On: oamg/leapp#677
@fernflower fernflower changed the title Report groups Introduce report Groups instead of Tags/Flags Nov 19, 2020
@fernflower fernflower changed the title Introduce report Groups instead of Tags/Flags Substitute report Tags/Flags with report Groups Nov 19, 2020
@fernflower fernflower removed the wip label Nov 19, 2020
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 19, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
9c029ba 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 20, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
2252dbf 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 23, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
2f94cc4 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Nov 23, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
c680330 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 1, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
b449a36 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 1, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
e7358c1 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 1, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
581af97 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 1, 2020
@fernflower
take pull request from TRAVIS_PULL_REQUEST in case of travis
e5c08cf 
The guessing is back for local make install-deps runs
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 1, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
3b463ed 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 1, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
c60c51e 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 2, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
2ffb372 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 2, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
62b4856 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 2, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
72eb3d5 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 2, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
e49e0d6 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 3, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
3ecc4a2 
Depends-On: oamg/leapp#677
fernflower added a commit to fernflower/leapp-repository that referenced this pull request Dec 3, 2020
@fernflower
Use Groups.POST in post upgrade actor reports
d234a1f 
Depends-On: oamg/leapp#677
@fernflower
Copy link
Member Author

Okay, this should be it, will schedule tests together with leapp-repository PR905 oamg/leapp-repository#905

@fernflower
Copy link
Member Author

/rerun 905

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4527283

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4527293

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/4527293;4527283 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/4527293;4527283 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4527293;4527283 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@fernflower
Copy link
Member Author

/rerun 905

fernflower added a commit to fernflower/leapp-repository that referenced this pull request Jun 13, 2022
@fernflower
Use library function is_inhibitor to check for failures
6bd8f5f 
This patch has to be merged together with leapp's PR677.

Depends-On: oamg/leapp#677

OAMG-1429
@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4528008

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4528248

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/4528248;4528008 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/4528248;4528008 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4528248;4528008 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@fernflower
Bump framework version
19f3d4e 
As this framework change is a breaking one, the
leapp-framework has to be bumped as per leapp
guidelines.

https://leapp.readthedocs.io/en/latest/compatibility-with-leapp-repository.html
@fernflower
Copy link
Member Author

/rerun 905

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4533859

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4533894

@github-actions
Copy link

Testing Farm request for RHEL-8.6-rhui/4533894;4533859 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/4533894;4533859 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/4533894;4533859 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/4533894;4533859 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

pirat89 pushed a commit to oamg/leapp-repository that referenced this pull request Jun 16, 2022
@fernflower @pirat89
Use library function is_inhibitor to check for failures
09ae300 
This patch has to be merged together with leapp's PR677.

Depends-On: oamg/leapp#677

OAMG-1429
@pirat89
Copy link
Member

pirat89 commented Jun 16, 2022

We have discussed the possible problems regarding dropped "flags" in the report msgs and it was decided we are going to drop it as the field itself has not been officially supported / documented. All repositories working with inhibitors must be updated however....

@pirat89 pirat89 merged commit 567400d into oamg:master Jun 16, 2022
pirat89 added a commit to pirat89/leapp that referenced this pull request Aug 23, 2022
@pirat89
# Release 0.15.0
08c650a 
## Packaging
-  bumped leapp-framework to 3.1 (oamg#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​oamg#784)
- Ignore invalid FQDNs (oamg#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788)
- Introduce `is_inhibitor` function (oamg#677)
- Introduce a `Blob` model field (oamg#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (oamg#785)
- Requires to be executed by root only (oamg#775)
@pirat89 pirat89 mentioned this pull request Aug 23, 2022
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Aug 23, 2022
@pirat89
# Release 0.15.0
558d299 
## Packaging
-  bumped leapp-framework to 3.1 (oamg#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​oamg#784)
- Ignore invalid FQDNs (oamg#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (oamg#677, oamg#781, oamg#788)
- Introduce `is_inhibitor` function (oamg#677)
- Introduce a `Blob` model field (oamg#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (oamg#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (oamg#785)
- Requires to be executed by root only (oamg#775)

Signed-off-by: Petr Stodulka <[email protected]>
MichalHe pushed a commit that referenced this pull request Aug 23, 2022
@pirat89
# Release 0.15.0 (#795)
866fcc8 
## Packaging
-  bumped leapp-framework to 3.1 (#677)

## Framework

### Fixes
- Fixed a problem where passing environment variables to an executed child process modified the environment variables of the parent process (​​#784)
- Ignore invalid FQDNs (#790)

### Enhancements
- Deprecate `reporting.(Tags|Flags)`, replaced by `reporting.Groups` (#677, #781, #788)
- Introduce `is_inhibitor` function (#677)
- Introduce a `Blob` model field (#789)
- Introduce new report JSON schema v1.2.0 (default: 1.1.0) (#677)

## Leapp (tool)

### Fixes
- Handle missing CLI commands gracefully (#785)
- Requires to be executed by root only (#775)

Signed-off-by: Petr Stodulka <[email protected]>

Signed-off-by: Petr Stodulka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernflower @centos-ci @leapp-bot @pirat89