Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tags #650

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add new tags #650

merged 1 commit into from
Jul 14, 2020

Conversation

Rezney
Copy link
Member

@Rezney Rezney commented Jul 14, 2020

No description provided.

@centos-ci
Copy link

Can one of the admins verify this patch?

@leapp-bot
Copy link
Collaborator

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines, pass tests and linter checks before it can be merged.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests and copr build
  • e2e tests to run unit tests, copr build and end-to-end tests (OAMG members only)
  • review please to notify leapp developers of review request

@bocekm
Copy link
Member

bocekm commented Jul 14, 2020

Aren't messages regarding RHUI always going to relate to public clouds and vice versa? Wouldn't just one tag suffice?

@Rezney
Copy link
Member Author

Rezney commented Jul 14, 2020

In my mind, these two together can reach wider audience which to me sounds like purpose of the tags.

@bocekm bocekm merged commit 7dda444 into oamg:master Jul 14, 2020
zhukovgreen
zhukovgreen reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@zhukovgreen zhukovgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice to have at least a description inside the MR:(

@pirat89
Copy link
Member

pirat89 commented Jul 20, 2020

This would be nice to have at least a description inside the MR:(

Yep. This was not prepared for merge as commit msg nor PR description properly filled.

@zhukovgreen zhukovgreen mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhukovgreen zhukovgreen zhukovgreen left review comments

@bocekm bocekm bocekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rezney @centos-ci @leapp-bot @bocekm @pirat89 @zhukovgreen