Add --actor-config to snactor run

[vinzenz]

This patch introduces support for specifying a model which the actor
should consume for configuration data.
Using this feature requires to run an actor before which produces this
model and saves the output.

Jira-Task: OAMG-1092

Signed-off-by: Vinzenz Feenstra [email protected]
Fixes #530

[leapp-bot]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines, pass tests and linter checks before it can be merged.

If you want to re-run tests or request review, you can use following commands as a comment:

• leapp-ci build to run unit tests and copr build
• e2e tests to run unit tests, copr build and end-to-end tests (OAMG members only)
• review please to notify leapp developers of review request

[Rezney]

Traceback (most recent call last):
  File "/usr/bin/snactor", line 9, in <module>
    load_entry_point('leapp==0.10.0', 'console_scripts', 'snactor')()
  File "/usr/lib/python2.7/site-packages/leapp/snactor/__init__.py", line 78, in main
    cli.command.execute(version=_('snactor version {}').format(VERSION))
  File "/usr/lib/python2.7/site-packages/leapp/utils/clicmd.py", line 103, in execute
    args.func(args)
  File "/usr/lib/python2.7/site-packages/leapp/utils/clicmd.py", line 125, in called
    self.target(args)
  File "/usr/lib/python2.7/site-packages/leapp/utils/repository.py", line 20, in checker
    return f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/leapp/snactor/context.py", line 32, in wrapper
    return f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/leapp/snactor/commands/run.py", line 46, in cli
    config_model = _get_model(args.actor_config, repository) if args.actor_config else None
  File "/usr/lib/python2.7/site-packages/leapp/snactor/commands/run.py", line 24, in _get_model
    return {model.__name__.lower(): model}[name.lower()]
NameError: global name 'model' is not defined

[Rezney]

@vinzenz is this still WIP?

[Rezney]

Tested, seems to be working fine. @pirat89 any potential comments here?

[Rezney]

@vinzenz I originally thought the failed tests was due to some outage but:

=================================== FAILURES ===================================

_____________ [pylint] leapp/snactor/commands/messages/__init__.py _____________

W: 15, 0: Reimport 'requires_repository' (imported line 11) (reimported)

============= 1 failed, 98 passed, 179 deselected in 27.71 seconds =============

could you please take a look?

[drehak]

Is the option only meant to be used for IPUConfig or other models too?
What about using the option multiple times with different models? The corresponding BaseMessaging attribute, _config_models is a tuple, but if I use the option multiple times, only the latter one gets used. (In the case it's not meant to be used multiple times, shouldn't such usage throw an error instead of some of them being silently discarded?)

[Rezney]

@drehak It is meant just for "IPUConfig" model as this is used differently then other models. Please note that you still have to run "IPUWorkflowConfig" actor to generate the data, same as to get the messages from other actors, which however do not require any special treatment. HTH.

[drehak]

@Rezney if it's for and only for IPUConfig, shouldn't the option just be a flag? Being able to specify any model as an argument is kinda pointless, if the argument is going to be IPUConfig anyway.

[Rezney]

@drehak To give a real example. We may (or may not) want to migrate Convert2RHEL to LEAPP. In this case, there would be a new repository, with a new workflow, and a new config model C2RConfig. HTH

[drehak]

@Rezney Alright, looks good to me then.

[Rezney]

@vinzenz could you please also document this?

[Rezney]

Doc added. Approved...