Stop adding 'process-end' audit entry #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Original reason for digging into this was that when trying to analyse DB content using "jq" tool, it failed as "process-end" was not JSON. So we can either remove it or change to JSON. What do you think @vinzenz ? |
|
@AloisMahdal heads up on this, if you rely on it somehow @Rezney I agree |
vinzenz
reviewed
Jul 17, 2019
leapp/utils/audit/__init__.py
Outdated
| @@ -283,7 +283,7 @@ def get_audit_entry(event, context): | |||
|
|
|||
| :param context: The execution context | |||
| :type context: str | |||
| :param event: Type of this event e.g. process-start or process-end but can be anything | |||
| :param event: Type of this event e.g. process-start or process-result but can be anything | |||
There was a problem hiding this comment.
Now that I see this, this is weird wording. Type of this event ... can be anything. It sounds like it can be of any type, which it can't. Identifier for this type of event, might be more clear.
|
Other than the documentation rewording this looks good to me. |
We already have "process-start" and "process-result" so we do not need "process-end" as it does not add any additional value.
Rezney
force-pushed
the
remove_process_end
branch
from
363b4df to
c28e7b5
Compare
|
@vinzenz thanks for checking this. Also good idea to ask @AloisMahdal so we do not break anything. Let's wait for his ack... |
|
Sorry, my github notifications reading morale was bad lately. Thanks for asking, but we don't query the db too much yet, and only the "messages" part and we just print it, so I don't think this should break tests. |
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Oct 24, 2019
## Packaging - Add the /var/log/leapp directory to the leapp RPM ## Framework ### Fixes - Handle string types in compatible way - Allow testing actors (run unit & component tests) with workflow config models ### Enhancements - Stop adding 'process-end' audit entry (oamg#538) - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage - Add additional metadata (hash) to reporting messages to be able to identify them uniquely ## Leapp ### Fixes - Various fixes in desplaying of generated reports - Show help message for proper subcommand ### Enhancements - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage ## Snactor ### Fixes - Fix processing of actors when two actors start with the same name (oamg#548) ### Enhancements - Add sanity-check command ## stdlib ### Fixes ### Enhancements - improve failed command error message - log external command errors to audit
Merged
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Oct 24, 2019
## Packaging - Add the /var/log/leapp directory to the leapp RPM ## Framework ### Fixes - Handle string types in compatible way - Allow testing actors (run unit & component tests) with workflow config models ### Enhancements - Stop adding 'process-end' audit entry (oamg#538) - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage - Add additional metadata (hash) to reporting messages to be able to identify them uniquely ## Leapp ### Fixes - Various fixes in displaying of generated reports - Show help message for proper subcommand ### Enhancements - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage ## Snactor ### Fixes - Fix processing of actors when two actors start with the same name (oamg#548) ### Enhancements - Add sanity-check command ## stdlib ### Fixes ### Enhancements - improve failed command error message - log external command errors to audit
pirat89
added a commit
that referenced
this pull request
Oct 24, 2019
## Packaging - Add the /var/log/leapp directory to the leapp RPM ## Framework ### Fixes - Handle string types in compatible way - Allow testing actors (run unit & component tests) with workflow config models ### Enhancements - Stop adding 'process-end' audit entry (#538) - Introduce report composability, remove renders (#543) - Introduce answerfile generation & usage - Add additional metadata (hash) to reporting messages to be able to identify them uniquely ## Leapp ### Fixes - Various fixes in displaying of generated reports - Show help message for proper subcommand ### Enhancements - Introduce report composability, remove renders (#543) - Introduce answerfile generation & usage ## Snactor ### Fixes - Fix processing of actors when two actors start with the same name (#548) ### Enhancements - Add sanity-check command ## stdlib ### Fixes ### Enhancements - improve failed command error message - log external command errors to audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have "process-start" and "process-result" so
we do not need "process-end" as it does not add any
additional value.