Inhibit upgrade if multiple kernel-debug pkgs are installed #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the If you want to re-run tests or request review, you can use following commands as a comment:
Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
pirat89
reviewed
Oct 26, 2020
| reporting.Tags([reporting.Tags.KERNEL]), | ||
| reporting.Flags([reporting.Flags.INHIBITOR]), | ||
| reporting.Remediation(hint=hint, commands=commands), | ||
| reporting.RelatedResource('package', 'kernel') |
There was a problem hiding this comment.
Shouldn't be here kernel-debug?
|
Tested, works fine. Please address @pirat89 's comment and we should be good to go. Thanks... |
When multiple kernel-debug packages are present, leapp can't process the transaction in some cases, so we inhibit the upgrade and present the user with hints on removing the surplus debug kernels. Note that the added actor is basically a search-and-replace copy of CheckInstalledDevelKernels, which solves the same problem for a different package. I don't see many reasons to merge them into one. Derived from: commit 2ce678f (oamg#457)
drehak
force-pushed
the
fix/kernel-debug-multiple
branch
from
23d95b3 to
f5ebd93
Compare
Rezney
approved these changes
Oct 27, 2020
drehak
added a commit
to drehak/leapp-repository
that referenced
this pull request
Feb 2, 2021
## Upgrade handling ### Fixes - Do not inhibit upgrade with SCA enabled manifest (oamg#615) - Fix false positive on some comments in /etc/default/grub (oamg#587) - Fix automated ipa-server removal (oamg#617) - Fix error at /boot/efi existing on non-EFI systems (oamg#627) - Fix syntax error in upgrade script (oamg#619) - Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599) - persistentnetnamesconfig: Fix crash on non-existent interface (oamg#625) ### Enhancements - Add a possibility to overwrite virtualenv name through environment variables (oamg#613) - Update product certificates (oamg#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
drehak
added a commit
to drehak/leapp-repository
that referenced
this pull request
Feb 2, 2021
## Upgrade handling ### Fixes - Do not inhibit upgrade with SCA enabled manifest (oamg#615) - Fix false positive on some comments in /etc/default/grub (oamg#587) - Fix automated ipa-server removal (oamg#617) - Fix error at /boot/efi existing on non-EFI systems (oamg#627) - Fix syntax error in upgrade script (oamg#619) - Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599) - persistentnetnamesconfig: Fix crash on non-existent interface (oamg#625) ### Enhancements - Add a possibility to overwrite virtualenv name through environment variables (oamg#613) - Update product certificates (oamg#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0 # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Tue Feb 2 15:57:58 2021 +0100 # # On branch release/202102 # Your branch is up to date with 'drehak/release/202102'. # # No changes
Merged
drehak
added a commit
to drehak/leapp-repository
that referenced
this pull request
Feb 4, 2021
## Packaging - Bump required leapp-framework capability to 1.4 (oamg#642) ## Upgrade handling ### Fixes - Fix comparison of the newest installed and booted kernel (oamg#600) - Fix remediation command for ipa-server removal (oamg#617) - Fix crash due to missing network interfaces during upgrade phases (oamg#625) - Fix error with /boot/efi existing on non-EFI systems (oamg#627) - Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587) - Fix syntax error in upgrade script (oamg#619) - Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639) - Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641) - Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599) - Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626) - Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611) ### Enhancements - Add upgrade support for SAP HANA (own upgrade path) (oamg#503) - Allow upgrade with SCA enabled manifest (oamg#615) - Add actors to migrate Quagga to FRR (oamg#467) - Add stable uniq Key id for every dialog (oamg#618) - Respect the *kernel-rt* package (oamg#600) ## Additional changes interesting for devels - Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613) - Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
drehak
added a commit
to drehak/leapp-repository
that referenced
this pull request
Feb 4, 2021
## Packaging - Bump required leapp-framework capability to 1.4 (oamg#642) ## Upgrade handling ### Fixes - Fix comparison of the newest installed and booted kernel (oamg#600) - Fix remediation command for ipa-server removal (oamg#617) - Fix crash due to missing network interfaces during upgrade phases (oamg#625) - Fix error with /boot/efi existing on non-EFI systems (oamg#627) - Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587) - Fix syntax error in upgrade script (oamg#619) - Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639) - Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641) - Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599) - Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626) - Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611) ### Enhancements - Add upgrade support for SAP HANA (own upgrade path) (oamg#503) - Allow upgrade with SCA enabled manifest (oamg#615) - Add actors to migrate Quagga to FRR (oamg#467) - Add stable uniq Key id for every dialog (oamg#618) - Respect the *kernel-rt* package (oamg#600) ## Additional changes interesting for devels - Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613) - Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
pirat89
pushed a commit
that referenced
this pull request
Feb 4, 2021
## Packaging - Bump required leapp-framework capability to 1.4 (#642) ## Upgrade handling ### Fixes - Fix comparison of the newest installed and booted kernel (#600) - Fix remediation command for ipa-server removal (#617) - Fix crash due to missing network interfaces during upgrade phases (#625) - Fix error with /boot/efi existing on non-EFI systems (#627) - Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (#587) - Fix syntax error in upgrade script (#619) - Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (#639) - Inhibit upgrade on s390x machines with /boot on a separate partition (#641) - Inhibit upgrade if multiple kernel-debug pkgs are installed (#599) - Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (#626) - Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (#611) ### Enhancements - Add upgrade support for SAP HANA (own upgrade path) (#503) - Allow upgrade with SCA enabled manifest (#615) - Add actors to migrate Quagga to FRR (#467) - Add stable uniq Key id for every dialog (#618) - Respect the *kernel-rt* package (#600) ## Additional changes interesting for devels - Add a possibility to overwrite virtualenv name using `$VENVNAME` (#613) - Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple kernel-debug packages are present, leapp can't process the transaction in some cases, so we inhibit the upgrade and present the user with hints on removing the surplus debug kernels.
Note that the added actor is basically a search-and-replace copy of CheckInstalledDevelKernels, which solves the same problem for a different package. I don't see many reasons to merge them into one.
Derived from: commit 2ce678f (#457)