Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checksaphana: Update link name to upgrade guide #1346

Merged
merged 1 commit into from
Feb 13, 2025
Merged

checksaphana: Update link name to upgrade guide #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions repos/system_upgrade/common/actors/checksaphana/libraries/checksaphana.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

def _report_skip_check():
summary = (
'For the target RHEL releases >=8.8 and >=9.2 '
'For the target RHEL releases >=8.8, >=9.2 and >=10.0 '
'the leapp utility does not check RHEL and SAP HANA 2.0 '
'versions compatibility. Please ensure your SAP HANA 2.0 '
'is supported on the target RHEL release and '
Expand Down Expand Up @@ -187,8 +187,6 @@ def version2_check(info):
continue
if version.matches_target_version('> 8.6', '< 9.0') or version.matches_target_version('> 9.0'):
# if a target release is >=8.8 or >=9.2, the SAP HANA and RHEL versions compatibility is not checked
# TODO(mmatuska): We don't know whether the check will be skipped on RHEL 10 (9to10) yet,
# update the method accoridingly then
_report_skip_check()
return
# if a starget release is 8.6 or 9.0 we still check SAP HANA and RHEL versions compatibility
Expand Down Expand Up @@ -243,14 +241,14 @@ def platform_check():

EXTERNAL_LINK = {
'8': reporting.ExternalLink(
url='https://access.redhat.com/solutions/5154031',
title='How to in-place upgrade SAP environments from RHEL 7 to RHEL 8'),
url='https://red.ht/how-to-in-place-upgrade-sap-environments-from-rhel-7-to-rhel-8',
title='Upgrading SAP environments from RHEL 7 to RHEL 8'),
'9': reporting.ExternalLink(
url='https://red.ht/how-to-in-place-upgrade-sap-environments-from-rhel-8-to-rhel-9',
title='How to in-place upgrade SAP environments from RHEL 8 to RHEL 9'),
title='Upgrading SAP environments from RHEL 8 to RHEL 9'),
'10': reporting.ExternalLink(
url='https://red.ht/how-to-in-place-upgrade-sap-environments-from-rhel-9-to-rhel-10',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title change presumes the link change too. Thefore we have 404 on it now.
plus it seems that shortcut was applicable to the previous doc portal, but not new one.

The correct link for 8to9 is https://docs.redhat.com/en/documentation/red_hat_enterprise_linux_for_sap_solutions/9/html/upgrading_sap_environments_from_rhel_8_to_rhel_9/index

and similarly for 7to8 https://docs.redhat.com/en/documentation/red_hat_enterprise_linux_for_sap_solutions/8/html/upgrading_sap_environments_from_rhel_7_to_rhel_8/index

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the same would be for 9to10, ie. https://docs.redhat.com/en/documentation/red_hat_enterprise_linux_for_sap_solutions/10/html/upgrading_sap_environments_from_rhel_9_to_rhel_10/index

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are changed outside of the code, we just change the redirects. This is so that we can change the redirects anytime and don't have to wait for a release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexxa yeah, about changed target URLs we know already. We will be fixing them during the next week together with other shortened URLs. But it seems that title should be updated also for 7 -> 8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I will update 7->8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and shortened URLs are expected to stay same. we will update only targets where they should point to.

title='How to in-place upgrade SAP environments from RHEL 9 to RHEL 10'),
title='Upgrading SAP environments from RHEL 9 to RHEL 10'),
}

reporting.create_report([
Expand Down