Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcidevicescanner: skip test_actor_execution if lspci is not installed #1114

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Aug 16, 2023

Checking the test it does not have so big value. The original functionality has been extended and the particular tests does not reflect it. Majority of the functionality is tested in unit tests around, so regarding that, I prefer for now to skip the test if lspci utility is not installed and get back to it later.

Note: also regarding running of integration tests, I think this particular unit test is not so important anymore. But there is no hard reason to drop it completely. The skip is better option in this case.

Checking the test it does not have so big value. The original
functionality has been extended and the particular tests does not
reflect it. Majority of the functionality is tested in unit tests
around, so regarding that, I prefer for now to skip the test if
lspci utility is not installed and get back to it later.
@pirat89 pirat89 requested a review from a team August 16, 2023 09:45
@github-actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

Copy link
Member

@matejmatuska matejmatuska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it's reasonable to skip this.

@pirat89 pirat89 merged commit 34d4629 into oamg:master Aug 16, 2023
@pirat89 pirat89 deleted the skip-lspci-test branch August 16, 2023 10:56
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants