Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the upgrade paths for SAP HANA #1077

Merged
merged 1 commit into from
May 11, 2023
Merged

Change the upgrade paths for SAP HANA #1077

merged 1 commit into from
May 11, 2023

Conversation

alexxa
Copy link
Contributor

@alexxa alexxa commented May 5, 2023 •
edited
Loading

Change the upgrade paths for SAP HANA hosts

  • Drop 7.9 to 8.2
  • Add 7.9 to 8.8, but keep 7.9 to 8.6 as default
  • Add 8.8 to 9.2
  • Drop SAP HANA version check starting from the target releases >=8.8 and >=9.2
  • Correct actor.py docstring to support ppc64le for 8to9 upgrade

@alexxa alexxa added the sap sap related changes label May 5, 2023
@alexxa alexxa requested review from vinzenz and pirat89 May 5, 2023 08:15
@github-actions
Copy link

github-actions bot commented May 5, 2023

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@alexxa alexxa marked this pull request as draft May 5, 2023 08:16
@alexxa
Copy link
Contributor Author

alexxa commented May 5, 2023

Please don't merge without ack from @berndfinger

@alexxa alexxa force-pushed the change_hana_paths branch 2 times, most recently from 5a1ee40 to 84b14e4 Compare May 9, 2023 13:06
@alexxa
Change the upgrade paths for SAP HANA
f5b1c1b 
 - Drop 7.9 to 8.2
 - Add 7.9 to 8.8, but keep 7.9 to 8.6 as default
 - Add 8.8 to 9.2
 - Drop SAP HANA version check for the target releases >=8.8 and >=9.2
 - Correct actor.py docstring to support ppc64le for 8to9 upgrade (see PR1042)
@alexxa alexxa force-pushed the change_hana_paths branch from 179b007 to f5b1c1b Compare May 11, 2023 11:00
@alexxa alexxa marked this pull request as ready for review May 11, 2023 11:03
pirat89
pirat89 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pirat89 pirat89 requested a review from vinzenz May 11, 2023 11:09
@pirat89 pirat89 dismissed vinzenz’s stale review May 11, 2023 11:25

discussed with Vinnie, he is fine with the current shape

@pirat89
Copy link
Member

pirat89 commented May 11, 2023

@alexxa let me know when you finish the testing :)

@berndfinger
Copy link
Contributor

lgtm

@pirat89 pirat89 merged commit 24bfccc into oamg:master May 11, 2023
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Jun 19, 2023
pirat89 added a commit to pirat89/leapp-repository that referenced this pull request Aug 23, 2023
@pirat89
Release 0.19.0
9819c7e 
## Packaging
- Requires leapp-framework 5.0

## Upgrade handling
### Fixes
- Add el8toel9 actor to handle directory -> symlink with ruby IRB. (oamg#1076)
- Do not try to update GRUB core on IBM Z systems (oamg#1117)
- Fix failing upgrades with devtmpfs file systems specified in FSTAB (oamg#1090)
- Fix the calculation of the required free space on each partitions/volume for the upgrade transactions (oamg#1097)
- Fix the generation of the report about hybrid images (oamg#1064)
- Handle correctly the installed certificates to allow upgrades with custom repositories using HTTPs with enabled SSL verification (oamg#1106)
- Minor improvements and fixes of various reports (oamg#1066, oamg#1067, oamg#1085)
- Update error messages about leapp data files to inform user how to obtain valid data files (oamg#1121)
- Update links in various reports (oamg#1062, oamg#1086)
- Update the repomap data to cover changed repoids in RHUI Azure (oamg#1087)
- [IPU 7 -> 8] Fix false positive report about invalid symlinks on RHEL 7 (oamg#1052)
- [IPU 8 -> 9] Inhibit the upgrade when unsupported x86-64 microarchitecture is detected (oamg#1059)

### Enhancements
- Include updated leapp data files in the RPM (oamg#1046, oamg#1092, oamg#1119)
- Update the set of supported upgrade paths (oamg#1077):
  - RHEL with SAP HANA 7.9 -> 8.6, 8.8 (default: 8.6)
  - RHEL with SAP HANA 8.8 -> 9.2
- Introduce new upgrade paths:
  - RHEL 7.9 -> 8.9 (default)
  - RHEL 8.9 -> 9.3
- Correctly update grub2 when /boot resides on multiple devices aggregated in RAID (oamg#1093, oamg#1115)
- Enable upgrades for machines using RHUI on AlibabaCloud (oamg#1088)
- Introduce possibility to add kernel drivers to initramfs (oamg#1081)
- Redesign handling of information about kernel (booted and target) in preparation for new changes in RHEL 9 (oamg#1107)
- Redesign source system overlay to use disk images backed by sparse files to optimize disk space consumption (oamg#1097, oamg#1103)
- Requires leapp-framework 5.0 (oamg#1061, oamg#1116)
- Use new leapp CLI API which provides better report summary output (oamg#1061, oamg#1116)
- [IPU 8 -> 9] Detect and report use of deprecated Xorg drivers (oamg#1078)
- [IPU 8 -> 9] Introduce IPU for systems with FIPS enabled (oamg#1053)

## Additional changes interesting for devels
- Deprecated `GrubInfo.orig_device_name` field in the `GrubInfo` model (replaced by `GrubInfo.orig_devices`) (oamg#1093)
- Deprecated `InstalledTargetKernelVersion` model (replaced by `InstalledTargetKernelInfo`) (oamg#1107)
- Deprecated `leapp.libraries.common.config.version.is_rhel_realtime` (check the type in msg `KernelInfo`, field `type`) (oamg#1107)
- Deprecated `leapp.libraries.common.grub.get_grub_device()` (replaced by `leapp.libraries.common.grub.get_grub_devices()`) (oamg#1093)
- Introduced new devel envar LEAPP_DEVEL_KEEP_DISK_IMGS=1 to skip the removal of the created disk images for OVL. That's sometimes handy for the debugging. (oamg#1097)
@pirat89 pirat89 mentioned this pull request Aug 23, 2023
Merged
Rezney pushed a commit that referenced this pull request Aug 23, 2023
@pirat89 @Rezney
Release 0.19.0
db25c79 
## Packaging
- Requires leapp-framework 5.0

## Upgrade handling
### Fixes
- Add el8toel9 actor to handle directory -> symlink with ruby IRB. (#1076)
- Do not try to update GRUB core on IBM Z systems (#1117)
- Fix failing upgrades with devtmpfs file systems specified in FSTAB (#1090)
- Fix the calculation of the required free space on each partitions/volume for the upgrade transactions (#1097)
- Fix the generation of the report about hybrid images (#1064)
- Handle correctly the installed certificates to allow upgrades with custom repositories using HTTPs with enabled SSL verification (#1106)
- Minor improvements and fixes of various reports (#1066, #1067, #1085)
- Update error messages about leapp data files to inform user how to obtain valid data files (#1121)
- Update links in various reports (#1062, #1086)
- Update the repomap data to cover changed repoids in RHUI Azure (#1087)
- [IPU 7 -> 8] Fix false positive report about invalid symlinks on RHEL 7 (#1052)
- [IPU 8 -> 9] Inhibit the upgrade when unsupported x86-64 microarchitecture is detected (#1059)

### Enhancements
- Include updated leapp data files in the RPM (#1046, #1092, #1119)
- Update the set of supported upgrade paths (#1077):
  - RHEL with SAP HANA 7.9 -> 8.6, 8.8 (default: 8.6)
  - RHEL with SAP HANA 8.8 -> 9.2
- Introduce new upgrade paths:
  - RHEL 7.9 -> 8.9 (default)
  - RHEL 8.9 -> 9.3
- Correctly update grub2 when /boot resides on multiple devices aggregated in RAID (#1093, #1115)
- Enable upgrades for machines using RHUI on AlibabaCloud (#1088)
- Introduce possibility to add kernel drivers to initramfs (#1081)
- Redesign handling of information about kernel (booted and target) in preparation for new changes in RHEL 9 (#1107)
- Redesign source system overlay to use disk images backed by sparse files to optimize disk space consumption (#1097, #1103)
- Requires leapp-framework 5.0 (#1061, #1116)
- Use new leapp CLI API which provides better report summary output (#1061, #1116)
- [IPU 8 -> 9] Detect and report use of deprecated Xorg drivers (#1078)
- [IPU 8 -> 9] Introduce IPU for systems with FIPS enabled (#1053)

## Additional changes interesting for devels
- Deprecated `GrubInfo.orig_device_name` field in the `GrubInfo` model (replaced by `GrubInfo.orig_devices`) (#1093)
- Deprecated `InstalledTargetKernelVersion` model (replaced by `InstalledTargetKernelInfo`) (#1107)
- Deprecated `leapp.libraries.common.config.version.is_rhel_realtime` (check the type in msg `KernelInfo`, field `type`) (#1107)
- Deprecated `leapp.libraries.common.grub.get_grub_device()` (replaced by `leapp.libraries.common.grub.get_grub_devices()`) (#1093)
- Introduced new devel envar LEAPP_DEVEL_KEEP_DISK_IMGS=1 to skip the removal of the created disk images for OVL. That's sometimes handy for the debugging. (#1097)
@pirat89 pirat89 added the report Any reports have been added / removed / changed in the PR label Nov 8, 2023
@pirat89
Copy link
Member

pirat89 commented Nov 8, 2023

@andywaltlova marking this by report flag also as once we start to support the upgrade too, it's something what user should definitely know/check before they upgrade (there is no user who would like to upgrade to newest rhel version with sap hana installed if it is not certified by sap yet)

@alexxa
Copy link
Contributor Author

alexxa commented Nov 8, 2023

@pirat89 what is "once we start to support the upgrade too" and the whole comment about please?
we still support the earlier release by default if HANA is detected to be on safer side, nevertheless, there is no any certification status check in the upgrade code, and we have it as a document warning, and whatever customers do, it's at their responsibility then

@andywaltlova
Copy link
Contributor

andywaltlova commented Nov 8, 2023 •
edited
Loading

I think @pirat89 wrote it in a hurry, it means once we will start to have upgrade task on red hat insights publicly available, we will want to be even more cautious on which systems we will show eligibility for upgrade - there is a rule which is basically saying 'your system is on upgrade path supported by leapp, do you want to try it? , we of course also render report in insights UI after preupgrade task runs and say everywhere that they should read it before proceeding, but.. well users.. :D they don't have upgrade task in UI yet so their 'experience on insights' now ends with remediations, but once the upgrade is added we just want to keep it in mind

@pirat89
Copy link
Member

pirat89 commented Nov 8, 2023 •
edited
Loading

@alexxa it's as @andywaltlova wrote, I was speaking about RH Insights stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

@vinzenz vinzenz Awaiting requested review from vinzenz

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant report Any reports have been added / removed / changed in the PR sap sap related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexxa @pirat89 @berndfinger @andywaltlova @vinzenz