Improve the "checkgrubcore" report message

No action is needed in case Leapp is able to detect the GRUB2 device
oamg · Apr 18, 2023 · ab59326 · ab59326
1 parent 035f5a9
commit ab59326
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/repos/system_upgrade/common/actors/checkgrubcore/actor.py b/repos/system_upgrade/common/actors/checkgrubcore/actor.py
@@ -6,8 +6,10 @@
 from leapp.reporting import create_report, Report
 from leapp.tags import ChecksPhaseTag, IPUWorkflowTag
 
-GRUB_SUMMARY = ('On legacy (BIOS) systems, GRUB core (located in the gap between the MBR and the '
-                'first partition) does not get automatically updated when GRUB is upgraded.')
+GRUB_SUMMARY = ('On legacy (BIOS) systems, GRUB2 core (located in the gap between the MBR and the '
+                'first partition) cannot be updated during the rpm transaction and Leapp has to initiate '
+                'the update running "grub2-install" after the transaction. No action is needed before the '
+                'upgrade. After the upgrade, it is recommended to check the GRUB configuration.')
 
 
 class CheckGrubCore(Actor):
@@ -33,21 +35,21 @@ def process(self):
             if grub_info.orig_device_name:
                 create_report([
                     reporting.Title(
-                        'GRUB core will be updated during upgrade'
+                        'GRUB2 core will be automatically updated during the upgrade'
                     ),
                     reporting.Summary(GRUB_SUMMARY),
                     reporting.Severity(reporting.Severity.HIGH),
                     reporting.Groups([reporting.Groups.BOOT]),
                 ])
             else:
                 create_report([
-                    reporting.Title('Leapp could not identify where GRUB core is located'),
+                    reporting.Title('Leapp could not identify where GRUB2 core is located'),
                     reporting.Summary(
-                        'We assume GRUB core is located on the same device as /boot. Leapp needs to '
-                        'update GRUB core as it is not done automatically on legacy (BIOS) systems. '
+                        'We assumed GRUB2 core is located on the same device as /boot, however Leapp could not '
+                        'detect GRUB2 on the device. GRUB2 core needs to be updated maually on legacy (BIOS) systems. '
                     ),
                     reporting.Severity(reporting.Severity.HIGH),
                     reporting.Groups([reporting.Groups.BOOT]),
                     reporting.Remediation(
-                        hint='Please run "grub2-install <GRUB_DEVICE> command manually after upgrade'),
+                        hint='Please run "grub2-install <GRUB_DEVICE> command manually after the upgrade'),
                 ])
diff --git a/repos/system_upgrade/common/actors/checkgrubcore/tests/test_checkgrubcore.py b/repos/system_upgrade/common/actors/checkgrubcore/tests/test_checkgrubcore.py
@@ -5,7 +5,7 @@
 from leapp.models import FirmwareFacts, GrubInfo
 from leapp.reporting import Report
 
-NO_GRUB = 'Leapp could not identify where GRUB core is located'
+NO_GRUB = 'Leapp could not identify where GRUB2 core is located'
 
 
 def test_actor_update_grub(current_actor_context):