Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: unmatched close-paren added to reader conditional #76

Closed
shaunlebron opened this issue Sep 5, 2024 · 1 comment
Closed

Bug: unmatched close-paren added to reader conditional #76

shaunlebron opened this issue Sep 5, 2024 · 1 comment
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release

Comments

@shaunlebron
Copy link

before:

(ns foo
  #?(:cljs (:require-macros [bar :refer [baz]])))

after:

(ns foo
  #?(:cljs
     (:require-macros
       [bar :refer [baz]]))))
;                           ^ unmatched close-paren
@shaunlebron shaunlebron changed the title Bug: unmatched-paren added to reader conditional Bug: unmatched close-paren added to reader conditional Sep 5, 2024
@oakmac oakmac added bug Something isn't working v1 blocker Required for a v1.0.0 release namespace related to ns form parsing or printing labels Sep 5, 2024
oakmac added a commit that referenced this issue Sep 5, 2024
@oakmac
GitHub Issue #76 - fix bug with ns closing parens related to require-…
7e50169 
…macros inside reader conditional
@oakmac oakmac mentioned this issue Sep 5, 2024
Merged
oakmac added a commit that referenced this issue Sep 5, 2024
@oakmac
GitHub Issue #76 - fix bug with ns require-macros inside reader condi…
1e1dc47 
…tional (#79)
@oakmac
Copy link
Owner

oakmac commented Sep 5, 2024

Thank you for the report!

Fixed with PR-79

@oakmac oakmac closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oakmac @shaunlebron