Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: tag literals #68

Closed
oakmac opened this issue Sep 4, 2024 · 3 comments
Closed

bug: tag literals #68

oakmac opened this issue Sep 4, 2024 · 3 comments
Labels
bug Something isn't working v1 blocker Required for a v1.0.0 release

Comments

@oakmac
Copy link
Owner

oakmac commented Sep 4, 2024

An alpha testing user found a bug while formatting Aero EDN files. Looks like it involves the # character. Need to investigate and create a minimal test case.

@oakmac oakmac added bug Something isn't working v1 blocker Required for a v1.0.0 release labels Sep 4, 2024
@oakmac oakmac changed the title bug: aero EDN files bug: tag literals Sep 4, 2024
oakmac added a commit that referenced this issue Sep 4, 2024
@oakmac
Copy link
Owner Author

oakmac commented Sep 4, 2024

Basic support added with PR-72.

Going to leave this issue open because we probably need to add some more test cases for tagged literals.

@oakmac
Copy link
Owner Author

oakmac commented Sep 28, 2024

I asked @shaunlebron to help out with this:


I took a quick look:

  1. tagged literals seem to be just a symbol followed by any form.
  2. luckily the formatter doesn’t have to care about anything other than reading the literal symbol and subsequent form, so we can ignore all the subtleties around evaluating them.
  3. I see your parser and format tests for tags seem to be working fine.
  4. I can’t think of any special formatting rules it should have, except for maybe removing any potential spaces between the # and symbol, since # inst "2024-09-26" is allowed. All other considerations should probably be handled by the existing rules for the literal types.

@oakmac
Copy link
Owner Author

oakmac commented Nov 29, 2024

Closing this for now; we can re-open if another breaking case is discovered.

@oakmac oakmac closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1 blocker Required for a v1.0.0 release
Projects
None yet
Development

No branches or pull requests

1 participant