Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting breaks the :require block! #166

Closed
licht1stein opened this issue Dec 2, 2024 · 4 comments
Closed

Formatting breaks the :require block! #166

licht1stein opened this issue Dec 2, 2024 · 4 comments
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release

Comments

@licht1stein
Copy link

This is a very serious issue for us, standard-clj doesn't seem to be handling the :rename form correctly.

It turns:

(ns hello
  (:require [other :refer :all :rename {foo bar}]))

into this:

(ns hello
  (:require
   [other :refer [bar foo]]))

Literally breaking the import and rendering the namespace unusable.

@oakmac oakmac added bug Something isn't working v1 blocker Required for a v1.0.0 release namespace related to ns form parsing or printing labels Dec 2, 2024
@oakmac
Copy link
Owner

oakmac commented Dec 3, 2024

Thank you for the report! Fixed with PR-167

@oakmac
Copy link
Owner

oakmac commented Dec 3, 2024

This fix is available with v0.17.0. Can you confirm that it works for your codebase @licht1stein ?

@licht1stein
Copy link
Author

Will check as soon as I have a chance, thanks for the quick fix!

@licht1stein
Copy link
Author

licht1stein commented Dec 3, 2024

Seems to be fine with version 0.18.0, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release
Projects
None yet
Development

No branches or pull requests

2 participants