Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken ns with reader conditionals #142

Closed
oakmac opened this issue Oct 25, 2024 · 2 comments
Closed

broken ns with reader conditionals #142

oakmac opened this issue Oct 25, 2024 · 2 comments
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release

Comments

@oakmac
Copy link
Owner

oakmac commented Oct 25, 2024

From cljs-math:

(ns ^{:doc "ClojureScript wrapper functions for math operations"
      :author "Paula Gearon" }
    cljs.math
  ;; create space to load this in Clojure for testing
  #?@(:clj ((:refer-clojure :exclude [aset aget + unsigned-bit-shift-right bit-shift-right bit-shift-left])
            (:require [js :refer [aset aget +]])
            (:import [js ArrayBuffer Uint8Array Uint32Array Float64Array]))))

#?(:clj (def number Double))
@oakmac oakmac added bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release labels Oct 25, 2024
@oakmac
Copy link
Owner Author

oakmac commented Oct 25, 2024

FYI for anyone who is effected by this bug before it is fixed:

Once this bug is fixed in Standard Clojure Style, it will reformat the ns form to look different than this. So it may be the path of least resistance to simply change your ns to something that Standard Clojure Style can correctly format. The end result will be the same before/after this bug is fixed.

@oakmac
Copy link
Owner Author

oakmac commented Oct 29, 2024

Fixed with PR-147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release
Projects
None yet
Development

No branches or pull requests

1 participant