Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with ns metadata + docstring #126

Closed
oakmac opened this issue Oct 17, 2024 · 1 comment
Closed

bug with ns metadata + docstring #126

oakmac opened this issue Oct 17, 2024 · 1 comment
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release

Comments

@oakmac
Copy link
Owner

oakmac commented Oct 17, 2024

Run fix on src/metabase/api/channel.clj:

diff --git a/src/metabase/api/channel.clj b/src/metabase/api/channel.clj
index 7bb7077605..2099f9d7ae 100644
--- a/src/metabase/api/channel.clj
+++ b/src/metabase/api/channel.clj
@@ -1,19 +1,20 @@
-(ns ^{:added "0.51.0"} metabase.api.channel
+(ns metabase.api.channel
   "/api/channel endpoints.
 
   Currently only used for http channels."
+  {:added "0.51.0"}
   (:require
-   [compojure.core :refer [DELETE GET POST PUT]]
-   [metabase.api.common :as api]
-   [metabase.api.common.validation :as validation]
-   [metabase.channel.core :as channel]
-   [metabase.events :as events]
-   [metabase.models.interface :as mi]
-   [metabase.util :as u]
-   [metabase.util.i18n :refer [deferred-tru]]
-   [metabase.util.malli :as mu]
-   [metabase.util.malli.schema :as ms]
-   [toucan2.core :as t2]))
+    [compojure.core :refer [DELETE GET POST PUT]]
+    [metabase.api.common :as api]
+    [metabase.api.common.validation :as validation]
+    [metabase.channel.core :as channel]
+    [metabase.events :as events]
+    [metabase.models.interface :as mi]
+    [metabase.util :as u]
+    [metabase.util.i18n :refer [deferred-tru]]
+    [metabase.util.malli :as mu]
+    [metabase.util.malli.schema :as ms]
+    [toucan2.core :as t2]))

Then run fix again, and it produces this diff:

diff --git a/src/metabase/api/channel.clj b/src/metabase/api/channel.clj
index 7bb7077605..ee56758e23 100644
--- a/src/metabase/api/channel.clj
+++ b/src/metabase/api/channel.clj
@@ -1,19 +1,17 @@
-(ns ^{:added "0.51.0"} metabase.api.channel
-  "/api/channel endpoints.
-
-  Currently only used for http channels."
+(ns metabase.api.channel
+  "0.51.0"
   (:require
-   [compojure.core :refer [DELETE GET POST PUT]]
-   [metabase.api.common :as api]
-   [metabase.api.common.validation :as validation]
-   [metabase.channel.core :as channel]
-   [metabase.events :as events]
-   [metabase.models.interface :as mi]
-   [metabase.util :as u]
-   [metabase.util.i18n :refer [deferred-tru]]
-   [metabase.util.malli :as mu]
-   [metabase.util.malli.schema :as ms]
-   [toucan2.core :as t2]))
+    [compojure.core :refer [DELETE GET POST PUT]]
+    [metabase.api.common :as api]
+    [metabase.api.common.validation :as validation]
+    [metabase.channel.core :as channel]
+    [metabase.events :as events]
+    [metabase.models.interface :as mi]
+    [metabase.util :as u]
+    [metabase.util.i18n :refer [deferred-tru]]
+    [metabase.util.malli :as mu]
+    [metabase.util.malli.schema :as ms]
+    [toucan2.core :as t2]))
@oakmac oakmac added bug Something isn't working v1 blocker Required for a v1.0.0 release namespace related to ns form parsing or printing labels Oct 17, 2024
@oakmac
Copy link
Owner Author

oakmac commented Oct 18, 2024

Fixed with PR-127

@oakmac oakmac closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working namespace related to ns form parsing or printing v1 blocker Required for a v1.0.0 release
Projects
None yet
Development

No branches or pull requests

1 participant