fix: memory_ballooning for false value properly set #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
Currently, if the
memory_ballooningflag is set tofalse, the default-value check ofGetOkof the terraform sdk returns the status not found - therefore skipping setting the value. This results in the engine setting the value to the default one (true). This PR attempts to fix this by using theGetOkExistsfunction - which should be used carefully.hashicorp/terraform#15723
hashicorp/terraform-plugin-sdk#350
Are you the owner of the code you are sending in, or do you have permission of the owner?
yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
yes