Fixes 370: moves ovirt to internal directory #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
370-move-to-internal-dir
branch
from
1dfdc6d to
48a716d
Compare
engelmi
commented
May 25, 2022
| @@ -1,8 +1,10 @@ | |||
| //go:build tools | |||
| // +build tools | |||
| //go:build generate | |||
There was a problem hiding this comment.
I'd move the go:generate to the import to have it all in one place. If this is not desired, I can revert it, of course.
There was a problem hiding this comment.
If you now run go generate does it actually generate? Because this build will exclude it from the normal build process.
There was a problem hiding this comment.
According to https://pkg.go.dev/cmd/go/internal/generate:
The go generate tool also sets the build tag "generate" so that files may be examined by go generate but ignored during build.
It should generate it, yes. I tested it locally and it generated the doc when changing the tag to generate. (that is also the reason, why a change in the doc is in this PR)
There was a problem hiding this comment.
Maybe this would be something to submit to the SDK sample projects too?
ghost
approved these changes
May 25, 2022
engelmi
force-pushed
the
370-move-to-internal-dir
branch
from
48a716d to
fc9d943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
This PR fixes #370 and moves the ovirt directory to the internal directory.
Are you the owner of the code you are sending in, or do you have permission of the owner?
yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
yes