Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #343: new data-source for ovirt_disk_attachments #371

Merged
merged 1 commit into from
May 16, 2022

Conversation

engelmi
Copy link
Collaborator

@engelmi engelmi commented May 16, 2022

Please describe the change you are making

This PR fixes #343 and adds the ability to retrieve disk attachments by VM ID.

Are you the owner of the code you are sending in, or do you have permission of the owner?

yes

The code will be published under the BSD 3 clause license. Have you read and understood this license?

yes

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow New resource: ovirt_datacenter #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good code, please run go generate and verify the docs.

examples/data-sources/ovirt_disk_attachments/data.tf Outdated Show resolved Hide resolved
ovirt/provider.go Show resolved Hide resolved
@engelmi engelmi force-pushed the 343-data-source-disk-attachments branch from 74ba151 to b951811 Compare May 16, 2022 13:01
@engelmi engelmi merged commit 2b4c5d0 into oVirt:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ovirt_vm_disk_attachments data source
2 participants