Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/ovirt_vms: Export IP configurations of VM #174

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Sep 10, 2019

Signed-off-by: imjoey [email protected]

Issue #172 .

Changes proposed in this pull request:

  • Make the IP addresses exportable by adding new reported_devices attribute
  • Add acceptance testings for new attribute
  • Add missing docs for data source ovirt_vms

Output from acceptance testing:

$ make testacc TEST=./ovirt TESTARGS='-run=TestAccOvirtVMsDataSource_searchFilter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ovirt -v -run=TestAccOvirtVMsDataSource_searchFilter -timeout 180m
=== RUN   TestAccOvirtVMsDataSource_searchFilter
--- PASS: TestAccOvirtVMsDataSource_searchFilter (0.80s)
PASS
ok      github.com/ovirt/terraform-provider-ovirt/ovirt 0.834s

@imjoey imjoey merged commit 268ed66 into oVirt:master Sep 10, 2019
@imjoey imjoey deleted the add_reported_devices_for_ds_vms branch September 10, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant