Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: ovirt_nics #173

Merged
merged 1 commit into from
Sep 10, 2019
Merged

New Data Source: ovirt_nics #173

merged 1 commit into from
Sep 10, 2019

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Sep 10, 2019

Signed-off-by: imjoey [email protected]

Changes proposed in this pull request:

  • Add support for new data source ovirt_nics to provide the details
    about the NICs of a VM, or a Template (not supported yet)
  • Add acceptance testing for this new data source
  • Add relevant docs

Output from acceptance testing:

$ make testacc  TEST=./ovirt TESTARGS='-run=TestAccOvirtNicsDataSource_nameRegexFilter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ovirt -v -run=TestAccOvirtNicsDataSource_nameRegexFilter -timeout 180m
=== RUN   TestAccOvirtNicsDataSource_nameRegexFilter
--- PASS: TestAccOvirtNicsDataSource_nameRegexFilter (0.55s)
PASS
ok      github.com/ovirt/terraform-provider-ovirt/ovirt 0.576s

@imjoey
New data source: ovirt_nics
42fc313 
Add support for new data source `ovirt_nics` to provide the details
about the NICs of a VM, or a Template (not supported yet).

Signed-off-by: imjoey <[email protected]>
@imjoey imjoey merged commit 3b4cfbc into oVirt:master Sep 10, 2019
@imjoey imjoey deleted the new_ds_nic branch September 10, 2019 04:06
@imjoey imjoey mentioned this pull request Sep 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-data-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imjoey