Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/ovirt_vm: Do not change VM status after updating #167

Merged
merged 1 commit into from
Jul 31, 2019
Merged

resource/ovirt_vm: Do not change VM status after updating #167

merged 1 commit into from
Jul 31, 2019

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Jul 31, 2019

Signed-off-by: imjoey [email protected]

Issue #166 .

Changes proposed in this pull request:

  • After updating a VM, keep its original status without starting it
  • Improve the acceptance test cases for resource vm

Output from acceptance testing:

$ make testacc TEST=./ovirt TESTARGS='-run=TestAccOvirtVM_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ovirt -v -run=TestAccOvirtVM_basic -timeout 180m
=== RUN   TestAccOvirtVM_basic
--- PASS: TestAccOvirtVM_basic (94.16s)
PASS
ok      github.com/ovirt/terraform-provider-ovirt/ovirt 94.183s

@imjoey imjoey merged commit 9d6a846 into oVirt:master Jul 31, 2019
@imjoey imjoey deleted the no_state_change_updating_vm branch July 31, 2019 07:24
@imjoey imjoey mentioned this pull request Jul 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imjoey