Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add general purpose function to parse resource ID #163

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Add general purpose function to parse resource ID #163

merged 1 commit into from
Jul 11, 2019

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Jul 11, 2019

Signed-off-by: imjoey [email protected]

Changes proposed in this pull request:

  • Add a general helper function named parseResourceID to parse combined resource ID
  • Remove the legacy getXXIDAndYYID functions and use new parseResourceID function instead
  • Add test case for this new function

Output from testing:

$ go test ./ovirt -run "TestParseResourceID" -v
=== RUN   TestParseResourceID
--- PASS: TestParseResourceID (0.00s)
PASS
ok  	github.com/ovirt/terraform-provider-ovirt/ovirt	0.020s

@imjoey imjoey added enhancement New feature or request technical-debt labels Jul 11, 2019
@imjoey imjoey merged commit b78f491 into oVirt:master Jul 11, 2019
@imjoey imjoey deleted the add_resourceid_parser branch July 11, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imjoey