Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root_password visible in terraform plan #244

Closed
JasonN3 opened this issue Jan 21, 2021 · 1 comment · Fixed by #250
Closed

root_password visible in terraform plan #244

JasonN3 opened this issue Jan 21, 2021 · 1 comment · Fixed by #250

Comments

@JasonN3
Copy link

JasonN3 commented Jan 21, 2021

When running terraform plan, the root password is visible for new hosts. The field should be marked as sensitive using Sensitive: true, so the output will show "(sensitive value)" instead of the actual value. Any other resource types with a password should have the same thing done to them as well.

without "Sensitive: true":

resource "ovirt_host" "host" {
address = "host_addr"
cluster_id = "cluster_id"
id = (known after apply)
name = "host_name"
root_password = "YourSecurePassword"
}

with "Sensitive: true":

resource "ovirt_host" "host" {
address = "host_addr"
cluster_id = "cluster_id"
id = (known after apply)
name = "host_name"
root_password = (sensitive value)
}

emesika added a commit that referenced this issue Mar 18, 2021
Fixes #244: root_password visible in terraform plan
@ghost
Copy link

ghost commented Mar 18, 2021

@JasonN3 thank you for your report. We have merged the patch and it will be in the next release (coming shortly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant