Add warning for Boot menu switch on running VM. #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareklibra
approved these changes
Apr 10, 2018
| isUp && | ||
| <React.Fragment> | ||
| <span className='pficon pficon-warning-triangle-o' /> | ||
| |
There was a problem hiding this comment.
In this case, use of padding would be better.
Considering time constraint, let's keep it for a follow-up.
| @@ -262,6 +262,7 @@ export const messages = { | |||
| network: 'Network', | |||
| noNetwork: 'No network', | |||
| vnicProfileEmpty: '<Empty>', | |||
| bootMenuWarning: 'All changes will take effect only after reboot!', | |||
There was a problem hiding this comment.
Please no exclamation mark ! in similar texts.
Considering time constraint, let's keep it for a follow-up
mareklibra
reviewed
Apr 10, 2018
| @@ -435,6 +435,7 @@ class VmDialog extends React.Component { | |||
| } | |||
|
|
|||
| const isEdit = !!vm | |||
| const isUp = (isEdit && vm.get('status') === 'up') | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #549
Running VM:
Not running VM:
This change is