Fixed align of Delete buttons for Disks #553
Conversation
src/components/VmDisks/style.css
Outdated
| @@ -27,3 +28,14 @@ | |||
| font-size: small; | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .vmdisk-item { | |||
There was a problem hiding this comment.
I would make these more generic, not just for vmdisk.
Isn't there same issue for networks?
What about potential future list of other objects on the same place?
There was a problem hiding this comment.
Provided we have time for this, it would surely be nice to have a component. I wouldn't go for anything complex like AddRemoveListing but rather use something purely visual like AlignedListing
| @@ -8,6 +8,7 @@ | |||
| list-style-type: none; | |||
| padding: 0; | |||
| margin-bottom: 0px !important; | |||
| display: table; | |||
There was a problem hiding this comment.
I find this difficult to read and debug. This actually relies on generation of virtual, DOM invisible, row and tr elements as described at Anonymous table objects css spec. I find it much more clear to openly admit that we are actually creating complete css table and use appropriate display values for li (table-row) and span (table-cell) elements.
bond95
force-pushed
the
align-disk-delete
branch
from
760cc5e to
dc06363
Compare
|
@jniederm Done. |
bond95
force-pushed
the
align-disk-delete
branch
from
dc06363 to
6cb305a
Compare
| @@ -93,16 +93,17 @@ class VmDisk extends React.PureComponent { | |||
|
|
|||
| return ( | |||
| <li> | |||
| <span id={`${idPrefix}`}> | |||
There was a problem hiding this comment.
Please do not remove id attributes, they are referenced from Selenium tests
Bug: When some disk is bootable, arrangment is broke. Fixes: oVirt#544
bond95
force-pushed
the
align-disk-delete
branch
from
6cb305a to
d0038c3
Compare
|
@mareklibra Done. |
Bug: When some disk is bootable, arrangment is broke.
Fixes: #544
This change is