Fixed bug with "Loading..." message when SSH key is empty. #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniederm
suggested changes
Mar 9, 2018
| @@ -10,8 +10,12 @@ function* saveSSHKey (sagas, action) { | |||
| function* getSSHKey (sagas, action) { | |||
| yield put(setUnloaded()) | |||
| const result = yield sagas.callExternalAction('getSSHKey', Api.getSSHKey, action) | |||
| if (!result.error && result.ssh_public_key && result.ssh_public_key.length > 0) { | |||
| yield put(setSSHKey(Api.SSHKeyToInternal({ sshKey: result.ssh_public_key[0] }))) | |||
| if (!result.error) { | |||
There was a problem hiding this comment.
can we please use "return fast" approach.
if (result.error) {
return
}
// ...I believe it improves readability, and it certainly saves my mind stack.
Bug: If there is no SSH key saved for user, then in OptionDialog "Loading..." message doesn't disappear Fixes: oVirt#505
|
@jniederm Done. |
mareklibra
approved these changes
Mar 14, 2018
mareklibra
added a commit
that referenced
this pull request
Mar 22, 2018
Merged
mareklibra
added a commit
that referenced
this pull request
Mar 22, 2018
mareklibra
added a commit
that referenced
this pull request
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: If there is no SSH key saved for user, then in OptionDialog "Loading..." message doesn't disappear
Fixes: #505
This change is